You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "danielcarletti (via GitHub)" <gi...@apache.org> on 2025/04/02 16:36:45 UTC

[PR] Bump helm version in docs due to break statement [airflow]

danielcarletti opened a new pull request, #48700:
URL: https://github.com/apache/airflow/pull/48700

   ## Bump Helm Version Requirement to 3.10+
   
   ### Description
   This PR updates the required Helm version for deploying Apache Airflow from `3.0+` to `3.10+`. The change aligns with the minimum version needed for compatibility with newer Helm features used in the Helm chart, particularly the `break` statement introduced in 972714e (in airflow/templates/rbac/pod-launcher-rolebinding.yaml:66)
   
   ### Related Issues
   N/A
   
   ### Changes Made
   - Updated Helm version requirement in relevant documentation and configurations.
   
   ### Testing
   - No functional changes were introduced.
   - Verified that Helm 3.10+ works as expected with the deployment.
   
   ### Checklist
   - [ ] My PR includes unit tests / doc updates if applicable.
   - [x] My PR follows the project's coding style and best practices.
   - [x] I have run `pre-commit` locally to validate formatting and linting.
   - [x] My PR is focused on a single change and does not introduce unrelated modifications.
   - [x] I have rebased my branch onto the latest `main`.
   - [x] All CI checks have passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump helm version in docs due to break statement [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #48700:
URL: https://github.com/apache/airflow/pull/48700#issuecomment-2773140834

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump helm version in docs due to break statement [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #48700:
URL: https://github.com/apache/airflow/pull/48700#issuecomment-2782662141

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump helm version in docs due to break statement [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #48700:
URL: https://github.com/apache/airflow/pull/48700


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org