You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2019/03/22 11:42:07 UTC
[hadoop] branch trunk updated: HADOOP-16201:
S3AFileSystem#innerMkdirs builds needless lists (#636)
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new ae2eb2d HADOOP-16201: S3AFileSystem#innerMkdirs builds needless lists (#636)
ae2eb2d is described below
commit ae2eb2dd4261e5fef964384efd168d9867eb94af
Author: Lokesh Jain <lo...@gmail.com>
AuthorDate: Fri Mar 22 17:12:00 2019 +0530
HADOOP-16201: S3AFileSystem#innerMkdirs builds needless lists (#636)
---
.../main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
index 1f560d0..f4c3d50 100644
--- a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
+++ b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
@@ -2295,10 +2295,6 @@ public class S3AFileSystem extends FileSystem implements StreamCapabilities,
LOG.debug("Making directory: {}", f);
entryPoint(INVOCATION_MKDIRS);
FileStatus fileStatus;
- List<Path> metadataStoreDirs = null;
- if (hasMetadataStore()) {
- metadataStoreDirs = new ArrayList<>();
- }
try {
fileStatus = getFileStatus(f);
@@ -2311,9 +2307,6 @@ public class S3AFileSystem extends FileSystem implements StreamCapabilities,
} catch (FileNotFoundException e) {
// Walk path to root, ensuring closest ancestor is a directory, not file
Path fPart = f.getParent();
- if (metadataStoreDirs != null) {
- metadataStoreDirs.add(f);
- }
while (fPart != null) {
try {
fileStatus = getFileStatus(fPart);
@@ -2327,11 +2320,6 @@ public class S3AFileSystem extends FileSystem implements StreamCapabilities,
}
} catch (FileNotFoundException fnfe) {
instrumentation.errorIgnored();
- // We create all missing directories in MetadataStore; it does not
- // infer directories exist by prefix like S3.
- if (metadataStoreDirs != null) {
- metadataStoreDirs.add(fPart);
- }
}
fPart = fPart.getParent();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org