You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/21 14:16:02 UTC
[GitHub] [beam] sfc-gh-kbregula opened a new pull request, #17426: Revert "Merge pull request #17223 from [BEAM-14215] Improve argument validation in SnowflakeIO"
sfc-gh-kbregula opened a new pull request, #17426:
URL: https://github.com/apache/beam/pull/17426
@reuvenlax commented that in some cases this change can cause regressions, so I revert the change.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #17426: Revert "Merge pull request #17223 from [BEAM-14215] Improve argument validation in SnowflakeIO"
Posted by GitBox <gi...@apache.org>.
aaltay merged PR #17426:
URL: https://github.com/apache/beam/pull/17426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17426: Revert "Merge pull request #17223 from [BEAM-14215] Improve argument validation in SnowflakeIO"
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17426:
URL: https://github.com/apache/beam/pull/17426#issuecomment-1105274089
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17426: Revert "Merge pull request #17223 from [BEAM-14215] Improve argument validation in SnowflakeIO"
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17426:
URL: https://github.com/apache/beam/pull/17426#issuecomment-1105274103
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #17426: Revert "Merge pull request #17223 from [BEAM-14215] Improve argument validation in SnowflakeIO"
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #17426:
URL: https://github.com/apache/beam/pull/17426#issuecomment-1105748111
LGTM - Clean revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17426: Revert "Merge pull request #17223 from [BEAM-14215] Improve argument validation in SnowflakeIO"
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17426:
URL: https://github.com/apache/beam/pull/17426#issuecomment-1105274098
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17426: Revert "Merge pull request #17223 from [BEAM-14215] Improve argument validation in SnowflakeIO"
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17426:
URL: https://github.com/apache/beam/pull/17426#issuecomment-1105274101
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #17426: Revert "Merge pull request #17223 from [BEAM-14215] Improve argument validation in SnowflakeIO"
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #17426:
URL: https://github.com/apache/beam/pull/17426#issuecomment-1105749600
Thank you for quickly addressing it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org