You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2005/04/14 13:24:56 UTC
Re: svn commit: r14194 - in trunk/subversion: mod_dav_svn
tests/clients/cmdline
On Thu, 14 Apr 2005 cmpilato@tigris.org wrote:
> Modified: trunk/subversion/mod_dav_svn/log.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/mod_dav_svn/log.c?view=diff&rev=14194&p1=trunk/subversion/mod_dav_svn/log.c&r1=14193&p2=trunk/subversion/mod_dav_svn/log.c&r2=14194
> ==============================================================================
> --- trunk/subversion/mod_dav_svn/log.c (original)
> +++ trunk/subversion/mod_dav_svn/log.c Thu Apr 14 03:24:56 2005
> @@ -244,40 +244,18 @@
> else if (strcmp(child->name, "end-revision") == 0)
> end = SVN_STR_TO_REV(dav_xml_get_cdata(child, resource->pool, 1));
> else if (strcmp(child->name, "limit") == 0)
> - {
> - limit = atoi(child->first_cdata.first->text);
> - }
> + limit = atoi(child->first_cdata.first->text);
Any particular reason to not fix this one?
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r14194 - in trunk/subversion: mod_dav_svn
tests/clients/cmdline
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Thu, 14 Apr 2005, C. Michael Pilato wrote:
> "Peter N. Lundblad" <pe...@famlundblad.se> writes:
>
> The answer to that may be found a bit further up in the patch:
>
> > > Modified: trunk/subversion/mod_dav_svn/log.c
> > > Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/mod_dav_svn/log.c?view=diff&rev=14194&p1=trunk/subversion/mod_dav_svn/log.c&r1=14193&p2=trunk/subversion/mod_dav_svn/log.c&r2=14194
> > > ==============================================================================
> > > --- trunk/subversion/mod_dav_svn/log.c (original)
> > > +++ trunk/subversion/mod_dav_svn/log.c Thu Apr 14 03:24:56 2005
> ^^^^^^^^
> Ah, yes -- there it is ---------------------------------------'
>
> :-)
>
Ha! ;)
> Feel free to fix (I'm likely to be dangerous to Subversion's codebase
> in my current state) -- I don't think it's backport-worthy (APR seems
> to only break up the chunks of CDATA on non-trivial things like
> character references and such, which shouldn't be present in the
> <limit> element).
>
That philosophy is broken, of course. Character/entity references are
legal in any contents and we shouldn't build such arbitrariness into our
code. But I agree about the non-need of backport. May fix later.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r14194 - in trunk/subversion: mod_dav_svn tests/clients/cmdline
Posted by "C. Michael Pilato" <cm...@collab.net>.
"Peter N. Lundblad" <pe...@famlundblad.se> writes:
> > else if (strcmp(child->name, "limit") == 0)
> > - {
> > - limit = atoi(child->first_cdata.first->text);
> > - }
> > + limit = atoi(child->first_cdata.first->text);
>
> Any particular reason to not fix this one?
The answer to that may be found a bit further up in the patch:
> > Modified: trunk/subversion/mod_dav_svn/log.c
> > Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/mod_dav_svn/log.c?view=diff&rev=14194&p1=trunk/subversion/mod_dav_svn/log.c&r1=14193&p2=trunk/subversion/mod_dav_svn/log.c&r2=14194
> > ==============================================================================
> > --- trunk/subversion/mod_dav_svn/log.c (original)
> > +++ trunk/subversion/mod_dav_svn/log.c Thu Apr 14 03:24:56 2005
^^^^^^^^
Ah, yes -- there it is ---------------------------------------'
:-)
Feel free to fix (I'm likely to be dangerous to Subversion's codebase
in my current state) -- I don't think it's backport-worthy (APR seems
to only break up the chunks of CDATA on non-trivial things like
character references and such, which shouldn't be present in the
<limit> element).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org