You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mh...@apache.org on 2019/09/06 12:31:18 UTC

[asterixdb] branch master updated: [NO ISSUE][STO] Increase Dataset Checkpoint Interval

This is an automated email from the ASF dual-hosted git repository.

mhubail pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 8154097  [NO ISSUE][STO] Increase Dataset Checkpoint Interval
8154097 is described below

commit 8154097da71086a4e38f475106e4f67115b1a07b
Author: Murtadha Hubail <mh...@apache.org>
AuthorDate: Fri Sep 6 02:27:15 2019 +0300

    [NO ISSUE][STO] Increase Dataset Checkpoint Interval
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    - The current dataset checkpoint interval of 10 mins
      is too small and can result in many unnecessary small
      flushes. This change increases the interval to 60 mins.
    
    Change-Id: Idd4d1d02e4df83833220bca05193c6a99393ac99
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/3546
    Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Murtadha Hubail <mh...@apache.org>
    Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Hussain Towaileb <hu...@gmail.com>
---
 .../runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm    | 2 +-
 .../results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm    | 2 +-
 .../results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm    | 2 +-
 .../java/org/apache/asterix/common/config/TransactionProperties.java    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
index 28b0c0e..a23829f 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
@@ -39,7 +39,7 @@
     "storage.max.active.writable.datasets" : 8,
     "txn\.commitprofiler\.enabled" : false,
     "txn\.commitprofiler\.reportinterval" : 5,
-    "txn\.dataset\.checkpoint\.interval" : 600,
+    "txn\.dataset\.checkpoint\.interval" : 3600,
     "txn\.job\.recovery\.memorysize" : 67108864,
     "txn\.lock\.escalationthreshold" : 1000,
     "txn\.lock\.shrinktimer" : 5000,
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
index 0b9194f..48e92b0 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
@@ -39,7 +39,7 @@
     "storage.max.active.writable.datasets" : 8,
     "txn\.commitprofiler\.enabled" : false,
     "txn\.commitprofiler\.reportinterval" : 5,
-    "txn\.dataset\.checkpoint\.interval" : 600,
+    "txn\.dataset\.checkpoint\.interval" : 3600,
     "txn\.job\.recovery\.memorysize" : 67108864,
     "txn\.lock\.escalationthreshold" : 1000,
     "txn\.lock\.shrinktimer" : 5000,
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
index 9f1cbb0..b631b8c 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
@@ -39,7 +39,7 @@
     "storage.max.active.writable.datasets" : 8,
     "txn\.commitprofiler\.enabled" : false,
     "txn\.commitprofiler\.reportinterval" : 5,
-    "txn\.dataset\.checkpoint\.interval" : 600,
+    "txn\.dataset\.checkpoint\.interval" : 3600,
     "txn\.job\.recovery\.memorysize" : 67108864,
     "txn\.lock\.escalationthreshold" : 1000,
     "txn\.lock\.shrinktimer" : 5000,
diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java
index 0477147..5ed069c 100644
--- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java
+++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/TransactionProperties.java
@@ -38,7 +38,7 @@ public class TransactionProperties extends AbstractProperties {
     public enum Option implements IOption {
         TXN_DATASET_CHECKPOINT_INTERVAL(
                 POSITIVE_INTEGER,
-                (int) TimeUnit.MINUTES.toSeconds(10),
+                (int) TimeUnit.MINUTES.toSeconds(60),
                 "The interval (in seconds) after which a dataset is considered idle and persisted to disk"),
         TXN_LOG_BUFFER_NUMPAGES(POSITIVE_INTEGER, 8, "The number of pages in the transaction log tail"),
         TXN_LOG_BUFFER_PAGESIZE(