[GitHub] [kafka] showuon commented on a change in pull request #11589: MINOR: update log and method name

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #11589:
URL: https://github.com/apache/kafka/pull/11589#discussion_r769211032



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##########
@@ -153,7 +153,7 @@ public void maybeNotifyTopologyVersionWaiters(final String threadName) {
                     if (threadVersions.values().stream().allMatch(t -> t >= topologyVersionWaitersVersion)) {
                         topologyVersionWaiters.future.complete(null);
                         iterator.remove();
-                        log.info("Thread {} is now on topology version {}", threadName, topologyVersionWaiters.topologyVersion);
+                        log.info("All threads are now on topology version {}", topologyVersionWaiters.topologyVersion);

Review comment:
       Sorry, some comments to this change:
   I can imagine after this PR, there will be some log output in `maybeNotifyTopologyVersionWaitersAndUpdateThreadsTopologyVersion` like this (if the `version.activeTopologyWaiters` has 3 waiters):
   ```
   [2021-12-15 08:52:59,397] INFO All threads are now on topology version 1
   [2021-12-15 08:52:59,397] INFO All threads are now on topology version 1
   [2021-12-15 08:52:59,397] INFO All threads are now on topology version 1
   ...
   ```
   I don't think the log is helpful. Could we add some other info here? Like: `All threads are now on topology version {}, removing the waiter {}, topologyVersionWaiters.topologyVersion, topologyVersionWaiters.future)`. WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org