You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Sebastian Schelter (JIRA)" <ji...@apache.org> on 2011/06/10 01:13:58 UTC
[jira] [Created] (MAHOUT-729) Refactoring: Use Maps.newHashMap()
and Lists.newArrayList() from Guava globally
Refactoring: Use Maps.newHashMap() and Lists.newArrayList() from Guava globally
-------------------------------------------------------------------------------
Key: MAHOUT-729
URL: https://issues.apache.org/jira/browse/MAHOUT-729
Project: Mahout
Issue Type: Improvement
Affects Versions: 0.6
Reporter: Sebastian Schelter
Assignee: Sebastian Schelter
I put on my refactoring hat today and started to replace all calls to "new HashMap" with Maps.newHashMap() as well as all calls to "new ArrayList" with Lists.newArrayList() from Guava. This should make the code much more readable as the generic type of a variable needs to be written only once per line. I also refactored some minor things I encountered along the way.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-729) Refactoring: Use Maps.newHashMap()
and Lists.newArrayList() from Guava globally
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Schelter updated MAHOUT-729:
--------------------------------------
Resolution: Fixed
Fix Version/s: 0.6
Status: Resolved (was: Patch Available)
> Refactoring: Use Maps.newHashMap() and Lists.newArrayList() from Guava globally
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-729
> URL: https://issues.apache.org/jira/browse/MAHOUT-729
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Fix For: 0.6
>
> Attachments: MAHOUT-729.patch
>
>
> I put on my refactoring hat today and started to replace all calls to "new HashMap" with Maps.newHashMap() as well as all calls to "new ArrayList" with Lists.newArrayList() from Guava. This should make the code much more readable as the generic type of a variable needs to be written only once per line. I also refactored some minor things I encountered along the way.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-729) Refactoring: Use Maps.newHashMap()
and Lists.newArrayList() from Guava globally
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047053#comment-13047053 ]
Sean Owen commented on MAHOUT-729:
----------------------------------
Yeah I think that's a nice change if you're willing to do it, and the patch looks fine.
> Refactoring: Use Maps.newHashMap() and Lists.newArrayList() from Guava globally
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-729
> URL: https://issues.apache.org/jira/browse/MAHOUT-729
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Attachments: MAHOUT-729.patch
>
>
> I put on my refactoring hat today and started to replace all calls to "new HashMap" with Maps.newHashMap() as well as all calls to "new ArrayList" with Lists.newArrayList() from Guava. This should make the code much more readable as the generic type of a variable needs to be written only once per line. I also refactored some minor things I encountered along the way.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-729) Refactoring: Use Maps.newHashMap()
and Lists.newArrayList() from Guava globally
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047807#comment-13047807 ]
Hudson commented on MAHOUT-729:
-------------------------------
Integrated in Mahout-Quality #877 (See [https://builds.apache.org/job/Mahout-Quality/877/])
MAHOUT-729 still more cleanup
MAHOUT-729 more cleanup
ssc : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134468
Files :
* /mahout/trunk/src/conf/driver.classes.props
ssc : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134462
Files :
* /mahout/trunk/integration/src/test/java/org/apache/mahout/text/SequenceFilesFromMailArchivesTest.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/classifier/bayes/SplitBayesInput.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/bayes/BayesAlgorithm.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/bayes/SequenceFileModelReader.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/bayes/mapreduce/cbayes/CBayesThetaNormalizerMapper.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/common/mapreduce/VectorSumReducer.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/bayes/CBayesAlgorithm.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/bayes/mapreduce/common/BayesTfIdfMapper.java
* /mahout/trunk/integration/src/main/java/org/apache/mahout/utils/vectors/arff/ARFFIterator.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/math/hadoop/MathHelper.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/common/mapreduce
* /mahout/trunk/examples/src/test/java/org/apache/mahout/classifier/bayes/SplitBayesInputTest.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/bayes/mapreduce/bayes/BayesClassifierDriver.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/cf/taste/example/grouplens/GroupLensDataModel.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/eval/ParallelFactorizationEvaluator.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/common/IOUtils.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/classifier/sgd/SimpleCsvExamples.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/eval/InMemoryFactorizationEvaluator.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/cf/taste/example/netflix/TransposeToByUser.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/bayes/mapreduce/bayes/BayesThetaNormalizerMapper.java
* /mahout/trunk/examples/src/main/java/org/apache/mahout/cf/taste/example/bookcrossing/BookCrossingDataModel.java
* /mahout/trunk/integration/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/GenericJDBCDataModel.java
* /mahout/trunk/integration/src/test/java/org/apache/mahout/utils/eval/ParallelFactorizationEvaluatorTest.java
> Refactoring: Use Maps.newHashMap() and Lists.newArrayList() from Guava globally
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-729
> URL: https://issues.apache.org/jira/browse/MAHOUT-729
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Attachments: MAHOUT-729.patch
>
>
> I put on my refactoring hat today and started to replace all calls to "new HashMap" with Maps.newHashMap() as well as all calls to "new ArrayList" with Lists.newArrayList() from Guava. This should make the code much more readable as the generic type of a variable needs to be written only once per line. I also refactored some minor things I encountered along the way.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-729) Refactoring: Use Maps.newHashMap()
and Lists.newArrayList() from Guava globally
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Schelter updated MAHOUT-729:
--------------------------------------
Attachment: MAHOUT-729.patch
> Refactoring: Use Maps.newHashMap() and Lists.newArrayList() from Guava globally
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-729
> URL: https://issues.apache.org/jira/browse/MAHOUT-729
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Attachments: MAHOUT-729.patch
>
>
> I put on my refactoring hat today and started to replace all calls to "new HashMap" with Maps.newHashMap() as well as all calls to "new ArrayList" with Lists.newArrayList() from Guava. This should make the code much more readable as the generic type of a variable needs to be written only once per line. I also refactored some minor things I encountered along the way.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-729) Refactoring: Use Maps.newHashMap()
and Lists.newArrayList() from Guava globally
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Schelter updated MAHOUT-729:
--------------------------------------
Status: Patch Available (was: Open)
will commit this in the next days if there are no objections
> Refactoring: Use Maps.newHashMap() and Lists.newArrayList() from Guava globally
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-729
> URL: https://issues.apache.org/jira/browse/MAHOUT-729
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Attachments: MAHOUT-729.patch
>
>
> I put on my refactoring hat today and started to replace all calls to "new HashMap" with Maps.newHashMap() as well as all calls to "new ArrayList" with Lists.newArrayList() from Guava. This should make the code much more readable as the generic type of a variable needs to be written only once per line. I also refactored some minor things I encountered along the way.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira