You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/02/02 21:49:56 UTC

[GitHub] [netbeans] sdedic commented on pull request #5413: Cleanup: removed dead/unused private methods. Part 1

sdedic commented on PR #5413:
URL: https://github.com/apache/netbeans/pull/5413#issuecomment-1414421737

   Could you split the commit somewhat ? For example one commit per cluster ? It could be easier to review.
   
   Please note that while removing dead code is good, we must be more careful in Platform or IDE clusters - it's possible that some other module hacked into the implementation using Reflection. It should not been done in the first place, I agree completely ... but this kind of ... things... happens in such long-lived codebase.
   
   So please let's be careful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists