[GitHub] [superset] geido commented on a change in pull request #16906: fix: Inclusive sign in time range display

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #16906:
URL: https://github.com/apache/superset/pull/16906#discussion_r719212358



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
##########
@@ -321,7 +321,8 @@ test('validates the pre-filter value', async () => {
   ).toBeInTheDocument();
 });
 
-test("doesn't render time range pre-filter if there are no temporal columns in datasource", async () => {
+// eslint-disable-next-line jest/no-disabled-tests
+test.skip("doesn't render time range pre-filter if there are no temporal columns in datasource", async () => {

Review comment:
       Hey @michael-s-molina just out of curiosity, what's the reason for skipping this test?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org