You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Geoffrey Young <ge...@modperlcookbook.org> on 2003/08/27 03:01:31 UTC
Re: cvs commit: modperl-2.0/t/response/TestModules proxy.pm
stas@apache.org wrote:
> stas 2003/08/26 16:28:04
>
> Modified: lib/ModPerl TestRun.pm
> Added: t/modules proxy.t
> t/response/TestModules proxy.pm
> Log:
> new test: converting a normal request to a proxy request
> - requires to bump up the number of maxclients to 2
this is a pretty big deal, as mod_perl tests have always run against a
single available server. are we sure that this isn't going to be
problematic on some platforms (namely win32, as usual :)? though I guess
from the docs MaxClients is meaningless to that mpm.
it also probably warrants something in Changes.
>
> Revision Changes Path
> 1.11 +7 -0 modperl-2.0/lib/ModPerl/TestRun.pm
>
> Index: TestRun.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/lib/ModPerl/TestRun.pm,v
> retrieving revision 1.10
> retrieving revision 1.11
> diff -u -r1.10 -r1.11
> --- TestRun.pm 26 Aug 2003 22:19:19 -0000 1.10
> +++ TestRun.pm 26 Aug 2003 23:28:04 -0000 1.11
> @@ -5,8 +5,15 @@
>
> use base qw(Apache::TestRunPerl);
>
> +# some mp2 tests require more than one server instance to be available
> +# without which the server may hang, waiting for the single server
> +# become available
> +use constant MIN_MAXCLIENTS => 2;
> +
> sub new_test_config {
> my $self = shift;
> +
> + $self->{conf_opts}->{maxclients} = MIN_MAXCLIENTS;
that's an oddly named constant for setting MaxClients. :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/t/response/TestModules proxy.pm
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
>>> this is a pretty big deal, as mod_perl tests have always run against
>>> a single available server. are we sure that this isn't going to be
>>> problematic on some platforms (namely win32, as usual :)? though I
>>> guess from the docs MaxClients is meaningless to that mpm.
>>
>>
>>
>> Not really, all tests designed to hit the same perl interpreter are
>> using the special API (grep for 'same_interp'). If you know of tests
>> that must be fixed, let me know.
>
>
> no, I don't. it's just that we all know that running in single-server
> mode is way different than running against multiple servers. I'm
> surprised you made the change so swiftly.
>
> remember what bugs you uncovered when you started running the tests in
> random order? this is the same kind of thing - introducing a new
> variable that may result in some new test failures for somebody.
What's your point? We shouldn't introduce new tests, if they require more than
one server?
If the tests that needed to be run against the same server were written
without ensuring that, those a broken test. Someone will discover that and we
will fix that.
Moreover, just like you sometimes miss problems when you run in a non-single
mode, you may miss problems when you run a single mode. I have seen both.
>> This change is needed for more upcoming tests. I'm planning to add SSL
>> tests and proxying over ssl, which will require more than one server
>> instance.
>>
>>> it also probably warrants something in Changes.
>>
>>
>>
>> not really, IMHO, this changes nothing in the mod_perl functionality.
>> Changes file is there to tell the important changes significant to
>> users, not internal changes and tweaks that don't affect them.
>
>
> ok. but don't say I didn't warn you when they come knocking :)
I'm not worried. Blowing up the Changes file with irrelevant information makes
it not very useful to users. Those who want the low-level details can use cvs
to get the commit logs.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/t/response/TestModules proxy.pm
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>> this is a pretty big deal, as mod_perl tests have always run against a
>> single available server. are we sure that this isn't going to be
>> problematic on some platforms (namely win32, as usual :)? though I
>> guess from the docs MaxClients is meaningless to that mpm.
>
>
> Not really, all tests designed to hit the same perl interpreter are
> using the special API (grep for 'same_interp'). If you know of tests
> that must be fixed, let me know.
no, I don't. it's just that we all know that running in single-server mode
is way different than running against multiple servers. I'm surprised you
made the change so swiftly.
remember what bugs you uncovered when you started running the tests in
random order? this is the same kind of thing - introducing a new variable
that may result in some new test failures for somebody.
>
> This change is needed for more upcoming tests. I'm planning to add SSL
> tests and proxying over ssl, which will require more than one server
> instance.
>
>> it also probably warrants something in Changes.
>
>
> not really, IMHO, this changes nothing in the mod_perl functionality.
> Changes file is there to tell the important changes significant to
> users, not internal changes and tweaks that don't affect them.
ok. but don't say I didn't warn you when they come knocking :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/t/response/TestModules proxy.pm
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
>
> stas@apache.org wrote:
>
>> stas 2003/08/26 16:28:04
>>
>> Modified: lib/ModPerl TestRun.pm
>> Added: t/modules proxy.t
>> t/response/TestModules proxy.pm
>> Log:
>> new test: converting a normal request to a proxy request
>> - requires to bump up the number of maxclients to 2
>
>
> this is a pretty big deal, as mod_perl tests have always run against a
> single available server. are we sure that this isn't going to be
> problematic on some platforms (namely win32, as usual :)? though I
> guess from the docs MaxClients is meaningless to that mpm.
Not really, all tests designed to hit the same perl interpreter are using the
special API (grep for 'same_interp'). If you know of tests that must be fixed,
let me know.
This change is needed for more upcoming tests. I'm planning to add SSL tests
and proxying over ssl, which will require more than one server instance.
> it also probably warrants something in Changes.
not really, IMHO, this changes nothing in the mod_perl functionality. Changes
file is there to tell the important changes significant to users, not internal
changes and tweaks that don't affect them.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org