You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/18 09:55:42 UTC
[GitHub] [phoenix] virajjasani opened a new pull request #1097: PHOENIX-5296 : refCount leak checks
virajjasani opened a new pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-764924839
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 12m 54s | 4.x passed |
| +1 :green_heart: | compile | 1m 44s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 34s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 26s | 4.x passed |
| +0 :ok: | spotbugs | 0m 28s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 26s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 12s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 9s | the patch passed |
| +1 :green_heart: | compile | 1m 41s | the patch passed |
| +1 :green_heart: | javac | 1m 41s | the patch passed |
| -1 :x: | checkstyle | 0m 35s | root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 25s | the patch passed |
| +1 :green_heart: | spotbugs | 5m 22s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 196m 15s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 3s | The patch does not generate ASF License warnings. |
| | | 247m 38s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.OrphanViewToolIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux d5ba4f42526d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 14e69c3 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/testReport/ |
| Max. process+thread count | 4691 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-762258588
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 55s | 4.x passed |
| +1 :green_heart: | compile | 1m 41s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 33s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 25s | 4.x passed |
| +0 :ok: | spotbugs | 0m 29s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 24s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 24s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 15s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 1s | the patch passed |
| +1 :green_heart: | compile | 1m 42s | the patch passed |
| +1 :green_heart: | javac | 1m 42s | the patch passed |
| -1 :x: | checkstyle | 0m 34s | root: The patch generated 10 new + 12 unchanged - 0 fixed = 22 total (was 12) |
| -1 :x: | whitespace | 0m 0s | The patch 31 line(s) with tabs. |
| +1 :green_heart: | javadoc | 1m 24s | the patch passed |
| +1 :green_heart: | spotbugs | 5m 19s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 178m 41s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 5s | The patch does not generate ASF License warnings. |
| | | 226m 17s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT |
| | phoenix.tx.TxCheckpointIT |
| | phoenix.end2end.OrphanViewToolIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 2bd20ca36f53 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 6fe6052 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/testReport/ |
| Max. process+thread count | 5470 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#discussion_r564287947
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java
##########
@@ -81,27 +88,27 @@
private static final String PHOENIX_NAMESPACE_MAPPED_SYSTEM_CATALOG = "SYSTEM:CATALOG";
private static final String PHOENIX_SYSTEM_CATALOG = "SYSTEM.CATALOG";
private static final String EXECUTE_UPGRADE_COMMAND = "EXECUTE UPGRADE";
- private static final String MODIFIED_MAX_VERSIONS ="5";
+ private static final String MODIFIED_MAX_VERSIONS = "5";
private static final String CREATE_TABLE_STMT = "CREATE TABLE %s"
- + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))";
+ + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))";
Review comment:
you meant `do not` match the conventions above right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani edited a comment on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-763638471
@stoty For 4.x, a couple more patch results are available on Jira. But master patch builds are still taking time. What do you suggest? Let's see some builds are anyways in progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani edited a comment on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-764408182
PR-1097#8 build timed out after 9 hr and PR-1097#9 is in progress. In the meanwhile, we have below build results available from precommit Jira for 4.x (QA results available on Jira):
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/367/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/368/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/369/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/370/
For PR-1096, both latest triggered builds were successful.
While precommit PR builds are serial, precommit Jira builds can run in parallel (consuming more resources?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-765190818
Just removed changes in `OrphanViewToolIT` from refCount check for now. Will try to add it later as separate Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#discussion_r564288734
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java
##########
@@ -81,27 +88,27 @@
private static final String PHOENIX_NAMESPACE_MAPPED_SYSTEM_CATALOG = "SYSTEM:CATALOG";
private static final String PHOENIX_SYSTEM_CATALOG = "SYSTEM.CATALOG";
private static final String EXECUTE_UPGRADE_COMMAND = "EXECUTE UPGRADE";
- private static final String MODIFIED_MAX_VERSIONS ="5";
+ private static final String MODIFIED_MAX_VERSIONS = "5";
private static final String CREATE_TABLE_STMT = "CREATE TABLE %s"
- + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))";
+ + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))";
Review comment:
https://phoenix.apache.org/develop.html details the steps for Eclipse and intelliJ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-764408182
PR-1097#8 build timed out after 9 hr and PR-1097#9 is in progress. In the meanwhile, we have below build results available from precommit Jira (QA results available on Jira):
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/367/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/368/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/369/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/370/
While precommit PR builds are serial, precommit Jira builds can run in parallel (consuming more resources?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-765698557
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 4m 58s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 58s | 4.x passed |
| +1 :green_heart: | compile | 1m 34s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 34s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 25s | 4.x passed |
| +0 :ok: | spotbugs | 0m 29s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 24s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 57s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 25s | the patch passed |
| +1 :green_heart: | compile | 1m 35s | the patch passed |
| +1 :green_heart: | javac | 1m 35s | the patch passed |
| -1 :x: | checkstyle | 0m 35s | root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 25s | the patch passed |
| -1 :x: | spotbugs | 0m 42s | phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) |
||| _ Other Tests _ |
| -1 :x: | unit | 151m 9s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 192m 44s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-hbase-compat-1.5.0 |
| | org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held At CompatUtil.java:lock held At CompatUtil.java:[line 61] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux a7764916236d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / a175cc0 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/testReport/ |
| Max. process+thread count | 5683 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1097: PHOENIX-5296 : Ensure store file reader refcount is zero at end of relevant unit tests
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-762278395
Once changes are finalized in #1096 , will get them here together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#discussion_r564286071
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java
##########
@@ -81,27 +88,27 @@
private static final String PHOENIX_NAMESPACE_MAPPED_SYSTEM_CATALOG = "SYSTEM:CATALOG";
private static final String PHOENIX_SYSTEM_CATALOG = "SYSTEM.CATALOG";
private static final String EXECUTE_UPGRADE_COMMAND = "EXECUTE UPGRADE";
- private static final String MODIFIED_MAX_VERSIONS ="5";
+ private static final String MODIFIED_MAX_VERSIONS = "5";
private static final String CREATE_TABLE_STMT = "CREATE TABLE %s"
- + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))";
+ + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))";
Review comment:
These line continuations do match the conventions in https://phoenix.apache.org/contributing.html .
I know that we have code in much worse shape than this, but since you are fixing formatting, we might as well do it by the book.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-762667962
Looks good, let's wait for the Yetus checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-766369929
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 8s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 54s | 4.x passed |
| +1 :green_heart: | compile | 1m 33s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 33s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 27s | 4.x passed |
| +0 :ok: | spotbugs | 0m 29s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 27s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 24s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 55s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 59s | the patch passed |
| +1 :green_heart: | compile | 1m 33s | the patch passed |
| +1 :green_heart: | javac | 1m 33s | the patch passed |
| -1 :x: | checkstyle | 0m 33s | root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 22s | the patch passed |
| -1 :x: | spotbugs | 0m 41s | phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) |
||| _ Other Tests _ |
| -1 :x: | unit | 140m 17s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 181m 9s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-hbase-compat-1.5.0 |
| | org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held At CompatUtil.java:lock held At CompatUtil.java:[line 61] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux d6b4ce08ea2c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 88f4362 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/testReport/ |
| Max. process+thread count | 5766 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-767464453
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 9s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 1s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 49s | 4.x passed |
| +1 :green_heart: | compile | 1m 39s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 36s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 25s | 4.x passed |
| +0 :ok: | spotbugs | 0m 29s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 24s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 15s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 39s | the patch passed |
| +1 :green_heart: | javac | 1m 39s | the patch passed |
| -1 :x: | checkstyle | 0m 33s | root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 25s | the patch passed |
| -1 :x: | spotbugs | 0m 40s | phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) |
||| _ Other Tests _ |
| -1 :x: | unit | 200m 18s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
| | | 244m 2s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-hbase-compat-1.5.0 |
| | org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held At CompatUtil.java:lock held At CompatUtil.java:[line 61] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/20/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux 7d82776da927 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 51715b3 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/20/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/20/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/20/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/20/testReport/ |
| Max. process+thread count | 4667 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/20/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani edited a comment on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-764408182
PR-1097#8 build timed out after 9 hr and PR-1097#9 is in progress. In the meanwhile, we have below build results available from precommit Jira for 4.x (QA results available on Jira):
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/367/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/368/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/369/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/370/
For PR-1096, both latest triggered builds were successful.
While precommit PR builds are serial, precommit Jira builds can run in parallel (consuming more resources?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-765038082
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 3s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 49s | 4.x passed |
| +1 :green_heart: | compile | 1m 54s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 39s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 43s | 4.x passed |
| +0 :ok: | spotbugs | 0m 32s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 30s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 27s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 37s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 14s | the patch passed |
| +1 :green_heart: | compile | 1m 52s | the patch passed |
| +1 :green_heart: | javac | 1m 52s | the patch passed |
| -1 :x: | checkstyle | 0m 40s | root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 39s | the patch passed |
| +1 :green_heart: | spotbugs | 6m 21s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 192m 30s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 7s | The patch does not generate ASF License warnings. |
| | | 244m 16s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.IndexScrutinyToolIT |
| | phoenix.end2end.AlterTableIT |
| | phoenix.end2end.OrphanViewToolIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux bb0bc265377b 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / d33f782 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/testReport/ |
| Max. process+thread count | 5130 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : Ensure store file reader refcount is zero at end of relevant unit tests
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-768124813
Comitted with updated commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-763638471
@stoty For 4.x, a couple more patch results are available on Jira. But master patch builds are still taking time. What do you suggest?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-765813496
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 53s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 4s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 12m 10s | 4.x passed |
| +1 :green_heart: | compile | 1m 40s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 35s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 23s | 4.x passed |
| +0 :ok: | spotbugs | 0m 30s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 56s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 46s | the patch passed |
| +1 :green_heart: | compile | 1m 31s | the patch passed |
| +1 :green_heart: | javac | 1m 31s | the patch passed |
| -1 :x: | checkstyle | 0m 34s | root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 24s | the patch passed |
| -1 :x: | spotbugs | 0m 41s | phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) |
||| _ Other Tests _ |
| -1 :x: | unit | 200m 39s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 56s | The patch does not generate ASF License warnings. |
| | | 249m 17s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-hbase-compat-1.5.0 |
| | org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held At CompatUtil.java:lock held At CompatUtil.java:[line 61] |
| Failed junit tests | phoenix.end2end.index.IndexMetadataIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux 928f3c781126 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / a175cc0 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/testReport/ |
| Max. process+thread count | 4807 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-764408182
PR-1097#8 build timed out after 9 hr and PR-1097#9 is in progress. In the meanwhile, we have below build results available from precommit Jira (QA results available on Jira):
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/367/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/368/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/369/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/370/
While precommit PR builds are serial, precommit Jira builds can run in parallel (consuming more resources?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#discussion_r564252606
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexAsyncThresholdIT.java
##########
@@ -69,51 +70,52 @@
private final boolean overThreshold;
private final Mode mode;
- enum Mode{
+ enum Mode {
NORMAL,
ASYNC,
COVERED,
FUNCTIONAL
- }
+ }
public IndexAsyncThresholdIT(Long threshold, Long rows, Long columns, Long overThreshold,
Long mode)
- throws Exception {
+ throws Exception {
this.tableName = generateUniqueName();
this.rows = rows;
this.columns = columns;
this.overThreshold = overThreshold == 0;
this.mode = mode.equals(0L) ? Mode.NORMAL :
- mode.equals(1L) ? Mode.ASYNC :
- mode.equals(2L) ? Mode.COVERED :
- Mode.FUNCTIONAL;
+ mode.equals(1L) ? Mode.ASYNC :
+ mode.equals(2L) ? Mode.COVERED :
+ Mode.FUNCTIONAL;
}
@Parameterized.Parameters
- public static synchronized Collection<Long[]> primeNumbers() {
+ public static synchronized Collection<Long[]> primeNumbers() {
return Arrays.asList(new Long[][]{
- {100000L, 5000L, 10L, 0L, 0L},
- {Long.MAX_VALUE, 200L, 100L, 1L, 0L},
- {0L, 20L, 10L, 1L, 0L},
- {1L, 20L, 10L, 1L, 1L},
- {1L, 20L, 10L, 0L, 2L},
- {1L, 100L, 10L, 0L, 3L},
+ {100000L, 5000L, 10L, 0L, 0L},
Review comment:
Your autoformatter doesn't seem to be set up right.
Continuation lines should either be matched to the previous expression, or use 8 spaces, not 4.
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexAsyncThresholdIT.java
##########
@@ -163,29 +164,28 @@ else if(this.mode == Mode.COVERED){
PMetaData metaCache = connection.unwrap(PhoenixConnection.class).getMetaDataCache();
List<PTable> indexes = metaCache.getTableRef(key).getTable().getIndexes();
if (!overThreshold) {
- if(this.mode == Mode.ASYNC){
+ if (this.mode == Mode.ASYNC) {
assertEquals(PIndexState.BUILDING, indexes.get(0).getIndexState());
- }
- else {
+ } else {
assertEquals(PIndexState.ACTIVE, indexes.get(0).getIndexState());
}
assertNull(exception);
} else {
assertEquals(0, indexes.size());
assertNotNull(exception);
assertEquals(exception.getErrorCode(),
- SQLExceptionCode.ABOVE_INDEX_NON_ASYNC_THRESHOLD.getErrorCode());
+ SQLExceptionCode.ABOVE_INDEX_NON_ASYNC_THRESHOLD.getErrorCode());
}
}
}
private void createAndPopulateTable(Connection conn, String fullTableName, Long rows,
Long columns)
- throws SQLException {
+ throws SQLException {
Statement stmt = conn.createStatement();
StringBuilder ddl = new StringBuilder("CREATE TABLE " + fullTableName
- + " (col1 varchar primary key");
- for (int i = 2; i< columns; i++){
+ + " (col1 varchar primary key");
Review comment:
indent 8 here too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-764924839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-763631389
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 0s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 0s | 4.x passed |
| +1 :green_heart: | compile | 1m 33s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 34s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 27s | 4.x passed |
| +0 :ok: | spotbugs | 0m 30s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 26s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 55s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 53s | the patch passed |
| +1 :green_heart: | compile | 1m 34s | the patch passed |
| +1 :green_heart: | javac | 1m 34s | the patch passed |
| -1 :x: | checkstyle | 0m 32s | root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 24s | the patch passed |
| +1 :green_heart: | spotbugs | 5m 6s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 133m 51s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 33s | The patch does not generate ASF License warnings. |
| | | 178m 28s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.SystemTablesCreationOnConnectionIT |
| | phoenix.end2end.salted.SaltedTableUpsertSelectIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux 6438e13c5354 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 14e69c3 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/testReport/ |
| Max. process+thread count | 5923 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : Ensure store file reader refcount is zero at end of relevant unit tests
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-767597455
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 5s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 2s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 56s | 4.x passed |
| +1 :green_heart: | compile | 1m 39s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 35s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 25s | 4.x passed |
| +0 :ok: | spotbugs | 0m 29s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 25s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 3m 14s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 39s | the patch passed |
| +1 :green_heart: | javac | 1m 39s | the patch passed |
| -1 :x: | checkstyle | 0m 33s | root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 25s | the patch passed |
| -1 :x: | spotbugs | 0m 40s | phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) |
||| _ Other Tests _ |
| -1 :x: | unit | 196m 6s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. |
| | | 239m 55s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-hbase-compat-1.5.0 |
| | org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held At CompatUtil.java:lock held At CompatUtil.java:[line 61] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux 3997859181e6 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 51715b3 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/testReport/ |
| Max. process+thread count | 4888 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-762634720
Sure, I am on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#discussion_r564287329
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java
##########
@@ -81,27 +88,27 @@
private static final String PHOENIX_NAMESPACE_MAPPED_SYSTEM_CATALOG = "SYSTEM:CATALOG";
private static final String PHOENIX_SYSTEM_CATALOG = "SYSTEM.CATALOG";
private static final String EXECUTE_UPGRADE_COMMAND = "EXECUTE UPGRADE";
- private static final String MODIFIED_MAX_VERSIONS ="5";
+ private static final String MODIFIED_MAX_VERSIONS = "5";
private static final String CREATE_TABLE_STMT = "CREATE TABLE %s"
- + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))";
+ + " (k1 VARCHAR NOT NULL, k2 VARCHAR, CONSTRAINT PK PRIMARY KEY(K1,K2))";
Review comment:
True, i just realized that i had continuation tab as `4` as opposed to `8`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-762867425
Build#2 is aborted, let's see how build#3 goes, it was lined up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-766369929
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 8s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 54s | 4.x passed |
| +1 :green_heart: | compile | 1m 33s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 33s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 27s | 4.x passed |
| +0 :ok: | spotbugs | 0m 29s | phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 27s | phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 24s | phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 55s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 59s | the patch passed |
| +1 :green_heart: | compile | 1m 33s | the patch passed |
| +1 :green_heart: | javac | 1m 33s | the patch passed |
| -1 :x: | checkstyle | 0m 33s | root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 22s | the patch passed |
| -1 :x: | spotbugs | 0m 41s | phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) |
||| _ Other Tests _ |
| -1 :x: | unit | 140m 17s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 181m 9s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-hbase-compat-1.5.0 |
| | org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held At CompatUtil.java:lock held At CompatUtil.java:[line 61] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1097 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux d6b4ce08ea2c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 88f4362 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/testReport/ |
| Max. process+thread count | 5766 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1097:
URL: https://github.com/apache/phoenix/pull/1097#issuecomment-763809588
Can you start one more for each branch ?
I'll probably merge it tomorrow morning-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org