You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by dashengju <gi...@git.apache.org> on 2014/06/13 08:10:23 UTC
[GitHub] incubator-storm pull request: STROM-351 multilang python process f...
GitHub user dashengju opened a pull request:
https://github.com/apache/incubator-storm/pull/140
STROM-351 multilang python process fall into endless loop
https://issues.apache.org/jira/browse/STORM-351
1. steps to reproduce
1) write a topology with a python bolt, run the topology on storm; then there will be two process for the bolt: the worker(java process for ShellBolt), python process.
2）kill -9 the worker(java process for ShellBolt);
2. expected behavior
the worker exit and the python process exist
3. actual, incorrect behavior
the worker exit, but the python process never exist and fall into endless loop
4. analyse
in storm.py，read tuple from stdin with follow function:
def readMsg():
msg = ""
while True:
line = sys.stdin.readline()[0:-1]
if line == "end":
break
msg = msg + line + "\n"
return json_decode(msg[0:-1])
when sys.stdin is closed, EOF is encountered, readline() return None, so readMsg fall into endless loop.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dashengju/incubator-storm Multilang_stormpy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #140
----
commit 7ce0bff2ca63c830e148385b4cce231152843d58
Author: JuDasheng <ju...@meituan.com>
Date: 2014-06-13T04:12:54Z
change bug of readMsg
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-351 multilang python process f...
Posted by dashengju <gi...@git.apache.org>.
Github user dashengju commented on the pull request:
https://github.com/apache/incubator-storm/pull/140#issuecomment-46259448
I have changed the title, thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STROM-351 multilang python process f...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/140#issuecomment-46248847
Oh one minor thing. s/STROM/STORM/ on the title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-351 multilang python process f...
Posted by dashengju <gi...@git.apache.org>.
Github user dashengju commented on the pull request:
https://github.com/apache/incubator-storm/pull/140#issuecomment-48563686
@d2r, @ptgoetz, please help to review this pull request, thank you very much
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-351 multilang python process f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-351 multilang python process f...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/140#issuecomment-48600374
Looks OK to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STROM-351 multilang python process f...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/140#issuecomment-46248697
The code change looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---