You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by stephane san <st...@gmail.com> on 2017/11/04 09:29:45 UTC
Re: Review Request 63558: AMBARI-22361: Fix bug in base_alert when
matching hostnames.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63558/
-----------------------------------------------------------
(Updated Nov. 4, 2017, 9:29 a.m.)
Review request for Ambari and Andrew Onischuk.
Changes
-------
Completed information fields
Bugs: https://issues.apache.org/jira/browse/AMBARI-19282
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-19282
Repository: ambari
Description
-------
In the ambari console, a critical alert gets reported for the NameNode Web UI due to mixed cases in hostname
Error at hand:
Connection failed to http://vz-sl-upupup-8724-hadoop-mgr-1:0 (<urlopen error [Errno 111] Connection refused>)
Issue:
While in HA mode the hdfs-site property
dfs.namenode.http-address.{{ha-nameservice}}.{{nn_id}}
may have upper case parts, which prevents matching the hostname.
The matching should be case insensitive and so both will be
converted to lower case before the matching is performed.
Fix:
lower case before doing the comparison
(samilar resolution as in https://issues.apache.org/jira/browse/AMBARI-19282)
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 05f80234d0
Diff: https://reviews.apache.org/r/63558/diff/1/
Testing
-------
Verified the ambari console doesn't report the critical alert any more.
(the ambari console reports http return code 200 when testing the NameNode Web UI access).
Thanks,
stephane san
Re: Review Request 63558: AMBARI-22361: Fix bug in base_alert when
matching hostnames.
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63558/#review190149
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 4, 2017, 11:42 a.m., stephane san wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63558/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2017, 11:42 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-22361
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-22361
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In the ambari console, a critical alert gets reported for the NameNode Web UI due to mixed cases in hostname
>
> Error at hand:
> Connection failed to http://vz-sl-upupup-8724-hadoop-mgr-1:0 (<urlopen error [Errno 111] Connection refused>)
>
> Issue:
> While in HA mode the hdfs-site property
> dfs.namenode.http-address.{{ha-nameservice}}.{{nn_id}}
> may have upper case parts, which prevents matching the hostname.
> The matching should be case insensitive and so both will be
> converted to lower case before the matching is performed.
>
> Fix:
> lower case before doing the comparison
> (samilar resolution as in https://issues.apache.org/jira/browse/AMBARI-19282)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 05f80234d0
>
>
> Diff: https://reviews.apache.org/r/63558/diff/1/
>
>
> Testing
> -------
>
> Verified the ambari console doesn't report the critical alert any more.
> (the ambari console reports http return code 200 when testing the NameNode Web UI access).
>
>
> Thanks,
>
> stephane san
>
>
Re: Review Request 63558: AMBARI-22361: Fix bug in base_alert when
matching hostnames.
Posted by stephane san <st...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63558/
-----------------------------------------------------------
(Updated Nov. 8, 2017, 12:30 p.m.)
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Bugs: AMBARI-22361
https://issues.apache.org/jira/browse/AMBARI-22361
Repository: ambari
Description
-------
In the ambari console, a critical alert gets reported for the NameNode Web UI due to mixed cases in hostname
Error at hand:
Connection failed to http://vz-sl-upupup-8724-hadoop-mgr-1:0 (<urlopen error [Errno 111] Connection refused>)
Issue:
While in HA mode the hdfs-site property
dfs.namenode.http-address.{{ha-nameservice}}.{{nn_id}}
may have upper case parts, which prevents matching the hostname.
The matching should be case insensitive and so both will be
converted to lower case before the matching is performed.
Fix:
lower case before doing the comparison
(samilar resolution as in https://issues.apache.org/jira/browse/AMBARI-19282)
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 05f80234d0
Diff: https://reviews.apache.org/r/63558/diff/1/
Testing
-------
Verified the ambari console doesn't report the critical alert any more.
(the ambari console reports http return code 200 when testing the NameNode Web UI access).
Thanks,
stephane san
Re: Review Request 63558: AMBARI-22361: Fix bug in base_alert when
matching hostnames.
Posted by stephane san <st...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63558/
-----------------------------------------------------------
(Updated Nov. 8, 2017, 12:27 p.m.)
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Bugs: https://issues.apache.org/jira/browse/AMBARI-22361
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-22361
Repository: ambari
Description
-------
In the ambari console, a critical alert gets reported for the NameNode Web UI due to mixed cases in hostname
Error at hand:
Connection failed to http://vz-sl-upupup-8724-hadoop-mgr-1:0 (<urlopen error [Errno 111] Connection refused>)
Issue:
While in HA mode the hdfs-site property
dfs.namenode.http-address.{{ha-nameservice}}.{{nn_id}}
may have upper case parts, which prevents matching the hostname.
The matching should be case insensitive and so both will be
converted to lower case before the matching is performed.
Fix:
lower case before doing the comparison
(samilar resolution as in https://issues.apache.org/jira/browse/AMBARI-19282)
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 05f80234d0
Diff: https://reviews.apache.org/r/63558/diff/1/
Testing
-------
Verified the ambari console doesn't report the critical alert any more.
(the ambari console reports http return code 200 when testing the NameNode Web UI access).
Thanks,
stephane san
Re: Review Request 63558: AMBARI-22361: Fix bug in base_alert when
matching hostnames.
Posted by stephane san <st...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63558/
-----------------------------------------------------------
(Updated Nov. 4, 2017, 9:42 a.m.)
Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
Changes
-------
Correct jira link
Bugs: https://issues.apache.org/jira/browse/AMBARI-22361
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-22361
Repository: ambari
Description
-------
In the ambari console, a critical alert gets reported for the NameNode Web UI due to mixed cases in hostname
Error at hand:
Connection failed to http://vz-sl-upupup-8724-hadoop-mgr-1:0 (<urlopen error [Errno 111] Connection refused>)
Issue:
While in HA mode the hdfs-site property
dfs.namenode.http-address.{{ha-nameservice}}.{{nn_id}}
may have upper case parts, which prevents matching the hostname.
The matching should be case insensitive and so both will be
converted to lower case before the matching is performed.
Fix:
lower case before doing the comparison
(samilar resolution as in https://issues.apache.org/jira/browse/AMBARI-19282)
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 05f80234d0
Diff: https://reviews.apache.org/r/63558/diff/1/
Testing
-------
Verified the ambari console doesn't report the critical alert any more.
(the ambari console reports http return code 200 when testing the NameNode Web UI access).
Thanks,
stephane san