[GitHub] spark pull request: [SPARK-2324] SparkContext should not exit dire...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/1274#issuecomment-51537965
  
    @aarondav @YanTangZhai I think that this patch introduced a bug in `Utils.getLocalDir()`.  Currently, that function assumes that all of the directories in `spark.local.dir` exist and returns the first directory from that list:
    
    ```scala
      /**
       * Get a temporary directory using Spark's spark.local.dir property, if set. This will always
       * return a single directory, even though the spark.local.dir property might be a list of
       * multiple paths.
       */
      def getLocalDir(conf: SparkConf): String = {
        conf.get("spark.local.dir", System.getProperty("java.io.tmpdir")).split(',')(0)
      }
    ```
    
    After this patch, the first directory might be missing, which can lead to confusing errors when we try to create files in it.
    
    How should we fix this?  Maybe have the disk manager be the authoritative source of local directories and update all other code to use it rather than the raw `spark.local.dir` property?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org