You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Hang Chen <ch...@apache.org> on 2022/01/10 06:47:44 UTC
[VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
This is the voting thread for PIP-122. It will stay open for at least 48
hours.
https://github.com/apache/pulsar/issues/13340
Pasted below for quoting convenience.
----
### Motivation
The ThresholdShedder load balance policy since Pulsar 2.6.0 by
https://github.com/apache/pulsar/pull/6772. It can resolve many load
balance issues of `OverloadShedder` and works well in many Pulsar
production clusters.
In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load balance
policy is `OverloadShedder`.
I think it's a good time for 2.10 to change default load balance
policy to `ThresholdShedder`, it will make throughput more balance
between brokers.
### Proposed Changes
In 2.10 release，for `broker.conf`, change
`loadBalancerLoadSheddingStrategy` from
`org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
`org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by Matteo Merli <ma...@gmail.com>.
+1
--
Matteo Merli
<ma...@gmail.com>
On Tue, Jan 11, 2022 at 12:05 PM Neng Lu <nl...@apache.org> wrote:
>
> +1 (non-binding)
>
> On Mon, Jan 10, 2022 at 12:39 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > +1 (binding)
> >
> > Enrico
> >
> > Il giorno lun 10 gen 2022 alle ore 07:47 Hang Chen
> > <ch...@apache.org> ha scritto:
> >
> > >
> > > This is the voting thread for PIP-122. It will stay open for at least 48
> > > hours.
> > >
> > > https://github.com/apache/pulsar/issues/13340
> > >
> > > Pasted below for quoting convenience.
> > >
> > > ----
> > >
> > > ### Motivation
> > > The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> > > https://github.com/apache/pulsar/pull/6772. It can resolve many load
> > > balance issues of `OverloadShedder` and works well in many Pulsar
> > > production clusters.
> > >
> > > In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load balance
> > > policy is `OverloadShedder`.
> > >
> > > I think it's a good time for 2.10 to change default load balance
> > > policy to `ThresholdShedder`, it will make throughput more balance
> > > between brokers.
> > >
> > > ### Proposed Changes
> > > In 2.10 release，for `broker.conf`, change
> > > `loadBalancerLoadSheddingStrategy` from
> > > `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> > > `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
> >
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by Neng Lu <nl...@apache.org>.
+1 (non-binding)
On Mon, Jan 10, 2022 at 12:39 AM Enrico Olivelli <eo...@gmail.com>
wrote:
> +1 (binding)
>
> Enrico
>
> Il giorno lun 10 gen 2022 alle ore 07:47 Hang Chen
> <ch...@apache.org> ha scritto:
>
> >
> > This is the voting thread for PIP-122. It will stay open for at least 48
> > hours.
> >
> > https://github.com/apache/pulsar/issues/13340
> >
> > Pasted below for quoting convenience.
> >
> > ----
> >
> > ### Motivation
> > The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> > https://github.com/apache/pulsar/pull/6772. It can resolve many load
> > balance issues of `OverloadShedder` and works well in many Pulsar
> > production clusters.
> >
> > In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load balance
> > policy is `OverloadShedder`.
> >
> > I think it's a good time for 2.10 to change default load balance
> > policy to `ThresholdShedder`, it will make throughput more balance
> > between brokers.
> >
> > ### Proposed Changes
> > In 2.10 release，for `broker.conf`, change
> > `loadBalancerLoadSheddingStrategy` from
> > `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> > `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
>
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
Enrico
Il giorno lun 10 gen 2022 alle ore 07:47 Hang Chen
<ch...@apache.org> ha scritto:
>
> This is the voting thread for PIP-122. It will stay open for at least 48
> hours.
>
> https://github.com/apache/pulsar/issues/13340
>
> Pasted below for quoting convenience.
>
> ----
>
> ### Motivation
> The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> https://github.com/apache/pulsar/pull/6772. It can resolve many load
> balance issues of `OverloadShedder` and works well in many Pulsar
> production clusters.
>
> In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load balance
> policy is `OverloadShedder`.
>
> I think it's a good time for 2.10 to change default load balance
> policy to `ThresholdShedder`, it will make throughput more balance
> between brokers.
>
> ### Proposed Changes
> In 2.10 release，for `broker.conf`, change
> `loadBalancerLoadSheddingStrategy` from
> `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by Hang Chen <ch...@apache.org>.
Thanks for your participation.
Close this vote with 3 (+1) bindings and 5 (+1) non-bindings, 0 (-1).
Regards,
Hang
PengHui Li <pe...@apache.org> 于2022年1月13日周四 11:03写道：
>
> +1
>
> Penghui
>
> On Thu, Jan 13, 2022 at 7:54 AM Aloys Zhang <al...@apache.org> wrote:
>
> > +1
> >
> > Michael Marshall <mm...@apache.org> 于2022年1月12日周三 13:37写道：
> >
> > > +1 - assuming we ensure that the `ThresholdShedder` has unit test
> > coverage.
> > >
> > > Thanks,
> > > Michael
> > >
> > >
> > > On Tue, Jan 11, 2022 at 9:53 PM rxl@apache.org <ranxiaolong716@gmail.com
> > >
> > > wrote:
> > > >
> > > > +1 (non-binding)
> > > >
> > > > --
> > > >
> > > > Thanks
> > > > Xiaolong Ran
> > > >
> > > > Haiting Jiang <ji...@apache.org> 于2022年1月12日周三 09:52写道：
> > > >
> > > > > +1
> > > > >
> > > > > On 2022/01/10 06:47:44 Hang Chen wrote:
> > > > > > This is the voting thread for PIP-122. It will stay open for at
> > > least 48
> > > > > > hours.
> > > > > >
> > > > > > https://github.com/apache/pulsar/issues/13340
> > > > > >
> > > > > > Pasted below for quoting convenience.
> > > > > >
> > > > > > ----
> > > > > >
> > > > > > ### Motivation
> > > > > > The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> > > > > > https://github.com/apache/pulsar/pull/6772. It can resolve many
> > load
> > > > > > balance issues of `OverloadShedder` and works well in many Pulsar
> > > > > > production clusters.
> > > > > >
> > > > > > In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load
> > > balance
> > > > > > policy is `OverloadShedder`.
> > > > > >
> > > > > > I think it's a good time for 2.10 to change default load balance
> > > > > > policy to `ThresholdShedder`, it will make throughput more balance
> > > > > > between brokers.
> > > > > >
> > > > > > ### Proposed Changes
> > > > > > In 2.10 release，for `broker.conf`, change
> > > > > > `loadBalancerLoadSheddingStrategy` from
> > > > > > `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> > > > > > `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
> > > > > >
> > > > >
> > >
> >
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by PengHui Li <pe...@apache.org>.
+1
Penghui
On Thu, Jan 13, 2022 at 7:54 AM Aloys Zhang <al...@apache.org> wrote:
> +1
>
> Michael Marshall <mm...@apache.org> 于2022年1月12日周三 13:37写道：
>
> > +1 - assuming we ensure that the `ThresholdShedder` has unit test
> coverage.
> >
> > Thanks,
> > Michael
> >
> >
> > On Tue, Jan 11, 2022 at 9:53 PM rxl@apache.org <ranxiaolong716@gmail.com
> >
> > wrote:
> > >
> > > +1 (non-binding)
> > >
> > > --
> > >
> > > Thanks
> > > Xiaolong Ran
> > >
> > > Haiting Jiang <ji...@apache.org> 于2022年1月12日周三 09:52写道：
> > >
> > > > +1
> > > >
> > > > On 2022/01/10 06:47:44 Hang Chen wrote:
> > > > > This is the voting thread for PIP-122. It will stay open for at
> > least 48
> > > > > hours.
> > > > >
> > > > > https://github.com/apache/pulsar/issues/13340
> > > > >
> > > > > Pasted below for quoting convenience.
> > > > >
> > > > > ----
> > > > >
> > > > > ### Motivation
> > > > > The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> > > > > https://github.com/apache/pulsar/pull/6772. It can resolve many
> load
> > > > > balance issues of `OverloadShedder` and works well in many Pulsar
> > > > > production clusters.
> > > > >
> > > > > In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load
> > balance
> > > > > policy is `OverloadShedder`.
> > > > >
> > > > > I think it's a good time for 2.10 to change default load balance
> > > > > policy to `ThresholdShedder`, it will make throughput more balance
> > > > > between brokers.
> > > > >
> > > > > ### Proposed Changes
> > > > > In 2.10 release，for `broker.conf`, change
> > > > > `loadBalancerLoadSheddingStrategy` from
> > > > > `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> > > > > `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
> > > > >
> > > >
> >
>
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by Aloys Zhang <al...@apache.org>.
+1
Michael Marshall <mm...@apache.org> 于2022年1月12日周三 13:37写道：
> +1 - assuming we ensure that the `ThresholdShedder` has unit test coverage.
>
> Thanks,
> Michael
>
>
> On Tue, Jan 11, 2022 at 9:53 PM rxl@apache.org <ra...@gmail.com>
> wrote:
> >
> > +1 (non-binding)
> >
> > --
> >
> > Thanks
> > Xiaolong Ran
> >
> > Haiting Jiang <ji...@apache.org> 于2022年1月12日周三 09:52写道：
> >
> > > +1
> > >
> > > On 2022/01/10 06:47:44 Hang Chen wrote:
> > > > This is the voting thread for PIP-122. It will stay open for at
> least 48
> > > > hours.
> > > >
> > > > https://github.com/apache/pulsar/issues/13340
> > > >
> > > > Pasted below for quoting convenience.
> > > >
> > > > ----
> > > >
> > > > ### Motivation
> > > > The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> > > > https://github.com/apache/pulsar/pull/6772. It can resolve many load
> > > > balance issues of `OverloadShedder` and works well in many Pulsar
> > > > production clusters.
> > > >
> > > > In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load
> balance
> > > > policy is `OverloadShedder`.
> > > >
> > > > I think it's a good time for 2.10 to change default load balance
> > > > policy to `ThresholdShedder`, it will make throughput more balance
> > > > between brokers.
> > > >
> > > > ### Proposed Changes
> > > > In 2.10 release，for `broker.conf`, change
> > > > `loadBalancerLoadSheddingStrategy` from
> > > > `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> > > > `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
> > > >
> > >
>
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by Michael Marshall <mm...@apache.org>.
+1 - assuming we ensure that the `ThresholdShedder` has unit test coverage.
Thanks,
Michael
On Tue, Jan 11, 2022 at 9:53 PM rxl@apache.org <ra...@gmail.com> wrote:
>
> +1 (non-binding)
>
> --
>
> Thanks
> Xiaolong Ran
>
> Haiting Jiang <ji...@apache.org> 于2022年1月12日周三 09:52写道：
>
> > +1
> >
> > On 2022/01/10 06:47:44 Hang Chen wrote:
> > > This is the voting thread for PIP-122. It will stay open for at least 48
> > > hours.
> > >
> > > https://github.com/apache/pulsar/issues/13340
> > >
> > > Pasted below for quoting convenience.
> > >
> > > ----
> > >
> > > ### Motivation
> > > The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> > > https://github.com/apache/pulsar/pull/6772. It can resolve many load
> > > balance issues of `OverloadShedder` and works well in many Pulsar
> > > production clusters.
> > >
> > > In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load balance
> > > policy is `OverloadShedder`.
> > >
> > > I think it's a good time for 2.10 to change default load balance
> > > policy to `ThresholdShedder`, it will make throughput more balance
> > > between brokers.
> > >
> > > ### Proposed Changes
> > > In 2.10 release，for `broker.conf`, change
> > > `loadBalancerLoadSheddingStrategy` from
> > > `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> > > `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
> > >
> >
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by "rxl@apache.org" <ra...@gmail.com>.
+1 (non-binding)
--
Thanks
Xiaolong Ran
Haiting Jiang <ji...@apache.org> 于2022年1月12日周三 09:52写道：
> +1
>
> On 2022/01/10 06:47:44 Hang Chen wrote:
> > This is the voting thread for PIP-122. It will stay open for at least 48
> > hours.
> >
> > https://github.com/apache/pulsar/issues/13340
> >
> > Pasted below for quoting convenience.
> >
> > ----
> >
> > ### Motivation
> > The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> > https://github.com/apache/pulsar/pull/6772. It can resolve many load
> > balance issues of `OverloadShedder` and works well in many Pulsar
> > production clusters.
> >
> > In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load balance
> > policy is `OverloadShedder`.
> >
> > I think it's a good time for 2.10 to change default load balance
> > policy to `ThresholdShedder`, it will make throughput more balance
> > between brokers.
> >
> > ### Proposed Changes
> > In 2.10 release，for `broker.conf`, change
> > `loadBalancerLoadSheddingStrategy` from
> > `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> > `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
> >
>
Re: [VOTE] PIP-122: Change loadBalancer default loadSheddingStrategy to ThresholdShedder
Posted by Haiting Jiang <ji...@apache.org>.
+1
On 2022/01/10 06:47:44 Hang Chen wrote:
> This is the voting thread for PIP-122. It will stay open for at least 48
> hours.
>
> https://github.com/apache/pulsar/issues/13340
>
> Pasted below for quoting convenience.
>
> ----
>
> ### Motivation
> The ThresholdShedder load balance policy since Pulsar 2.6.0 by
> https://github.com/apache/pulsar/pull/6772. It can resolve many load
> balance issues of `OverloadShedder` and works well in many Pulsar
> production clusters.
>
> In Pulsar 2.6.0, 2.7.0, 2.8.0 and 2.9.0, Pulsar's default load balance
> policy is `OverloadShedder`.
>
> I think it's a good time for 2.10 to change default load balance
> policy to `ThresholdShedder`, it will make throughput more balance
> between brokers.
>
> ### Proposed Changes
> In 2.10 release，for `broker.conf`, change
> `loadBalancerLoadSheddingStrategy` from
> `org.apache.pulsar.broker.loadbalance.impl.OverloadShedder` to
> `org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`
>