[GitHub] [skywalking] wu-sheng commented on issue #2846: Add config to control tracing sql parameters in MySQL agent

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #2846: Add config to control tracing sql parameters in MySQL agent
URL: https://github.com/apache/skywalking/pull/2846#issuecomment-500457552
 
 
   >there're methods like java.sql.PreparedStatement#setBinaryStream(int, java.io.InputStream, long), java.sql.PreparedStatement#setBlob(int, java.io.InputStream, long) and similar methods in PreparedStatement, should we collect them as well? The InputStream may be large and hard to display in tags, I would like to only collect their length and display something like InputStream[length] or anyone has better idea?
   
   You could simply ignore them. I don't think we need to do this with such high payload. For `InputStream[length]`, I am not sure whether it is worth to do.
   Also, based on this, your parameter tag value is not perfect. Thinking about these
   1. If one parameter is ignored somehow, parameter list would match, unless you keep a `?` or `InputStream` or something to be a placeholder.
   1. If the parameter includes `,`, what happens?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services