You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Peter Bacsko (JIRA)" <ji...@apache.org> on 2019/03/18 14:40:00 UTC

[jira] [Comment Edited] (YARN-9267) General improvements in FpgaResourceHandlerImpl

    [ https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795068#comment-16795068 ] 

Peter Bacsko edited comment on YARN-9267 at 3/18/19 2:39 PM:
-------------------------------------------------------------

[~devaraj.k] please check patch v6 which should be free of checkstyle issues.

Just to be safe, I added two SHA-256 related tests to {{TestFpgaResourceHandler}}.


was (Author: pbacsko):
[~devaraj.k] please check patch v6 which should be free of checkstyle issues.

> General improvements in FpgaResourceHandlerImpl
> -----------------------------------------------
>
>                 Key: YARN-9267
>                 URL: https://issues.apache.org/jira/browse/YARN-9267
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-9267-001.patch, YARN-9267-002.patch, YARN-9267-003.patch, YARN-9267-004.patch, YARN-9267-005.patch, YARN-9267-006.patch
>
>
> Fix some problems in {{FpgaResourceHandlerImpl}}:
>  * {{preStart()}} does not reconfigure card with the same IP - we see it as a problem. If you recompile the FPGA application, you must rename the aocx file because the card will not be reprogrammed. Suggestion: instead of storing Node<\->IPID mapping, store Node<\->IPID hash (like the SHA-256 of the localized file).
>  * Switch to slf4j from Apache Commons Logging
>  * Some unused imports



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org