You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/13 06:28:19 UTC
[GitHub] [spark] MaxGekk commented on a change in pull request #28189:
[SPARK-31426][SQL] Fix regressions of toJavaTimestamp/fromJavaTimestamp
MaxGekk commented on a change in pull request #28189: [SPARK-31426][SQL] Fix regressions of toJavaTimestamp/fromJavaTimestamp
URL: https://github.com/apache/spark/pull/28189#discussion_r407339048
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -496,8 +496,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
test("2016-03-13 02:00:00", tz, "2016-03-13 10:00:00.0")
test("2016-03-13 03:00:00", tz, "2016-03-13 10:00:00.0")
test("2016-11-06 00:59:59", tz, "2016-11-06 07:59:59.0")
- test("2016-11-06 01:00:00", tz, "2016-11-06 08:00:00.0")
- test("2016-11-06 01:59:59", tz, "2016-11-06 08:59:59.0")
+ test("2016-11-06 01:00:00", tz, "2016-11-06 09:00:00.0")
Review comment:
See the same test in 2.4 https://github.com/apache/spark/blob/branch-2.4/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala#L580-L581 but it sets PST time zone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org