You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/16 12:29:19 UTC

[GitHub] [iotdb] HelKim opened a new pull request #2857: [IOTDB-1234] fix ImportCsv tool cannot parse empty string

HelKim opened a new pull request #2857:
URL: https://github.com/apache/iotdb/pull/2857


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HelKim commented on a change in pull request #2857: [IOTDB-1234] fix ImportCsv tool cannot parse empty string

Posted by GitBox <gi...@apache.org>.
HelKim commented on a change in pull request #2857:
URL: https://github.com/apache/iotdb/pull/2857#discussion_r595876323



##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -47,29 +47,9 @@
 import org.apache.iotdb.db.qp.executor.PlanExecutor;
 import org.apache.iotdb.db.qp.logical.Operator.OperatorType;
 import org.apache.iotdb.db.qp.physical.PhysicalPlan;
-import org.apache.iotdb.db.qp.physical.crud.AggregationPlan;
-import org.apache.iotdb.db.qp.physical.crud.AlignByDevicePlan;
+import org.apache.iotdb.db.qp.physical.crud.*;

Review comment:
       > general, do not use import *...
   
   Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 commented on a change in pull request #2857: [IOTDB-1234] fix ImportCsv tool cannot parse empty string

Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2857:
URL: https://github.com/apache/iotdb/pull/2857#discussion_r595128398



##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -47,29 +47,9 @@
 import org.apache.iotdb.db.qp.executor.PlanExecutor;
 import org.apache.iotdb.db.qp.logical.Operator.OperatorType;
 import org.apache.iotdb.db.qp.physical.PhysicalPlan;
-import org.apache.iotdb.db.qp.physical.crud.AggregationPlan;
-import org.apache.iotdb.db.qp.physical.crud.AlignByDevicePlan;
+import org.apache.iotdb.db.qp.physical.crud.*;

Review comment:
       general,  do not use import  *...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jixuan1989 commented on pull request #2857: [IOTDB-1234] fix ImportCsv tool cannot parse empty string

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2857:
URL: https://github.com/apache/iotdb/pull/2857#issuecomment-802568121


   Hi, though the PR is merged, it left one thing... 
   You'd better add a Test for the case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jixuan1989 merged pull request #2857: [IOTDB-1234] fix ImportCsv tool cannot parse empty string

Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #2857:
URL: https://github.com/apache/iotdb/pull/2857


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jixuan1989 commented on pull request #2857: [IOTDB-1234] fix ImportCsv tool cannot parse empty string

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2857:
URL: https://github.com/apache/iotdb/pull/2857#issuecomment-802567341


   thanks for contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org