You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/24 08:58:53 UTC

[GitHub] TisonKun commented on a change in pull request #7815: [FLINK-11710][tests] Remove Instance usages in valid Test

TisonKun commented on a change in pull request #7815:  [FLINK-11710][tests] Remove Instance usages in valid Test
URL: https://github.com/apache/flink/pull/7815#discussion_r259609923
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
 ##########
 @@ -742,41 +704,32 @@ public void testFailureWhileRestarting() throws Exception {
 
 	private Scheduler createSchedulerWithInstances(int num, TaskManagerGateway taskManagerGateway) {
 		final Scheduler scheduler = new Scheduler(executor);
 
 Review comment:
   The last issue. We cannot replace it simply with `new TestingLogicalSlotProvider(num, gateway)` because the test based on it tests slot sharing. And for test coverage, we need a testing slot provider that implements slot provider semantic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services