You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2020/06/11 16:19:16 UTC
[Impala-ASF-CR] IMPALA-9107 (part 2): Add script to use the m2 archive tarball
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15735 )
Change subject: IMPALA-9107 (part 2): Add script to use the m2 archive tarball
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
LGTM
http://gerrit.cloudera.org:8080/#/c/15735/6/bin/jenkins/build-all-flag-combinations.sh
File bin/jenkins/build-all-flag-combinations.sh:
http://gerrit.cloudera.org:8080/#/c/15735/6/bin/jenkins/build-all-flag-combinations.sh@65
PS6, Line 65: mkdir -p ${TMP_DIR}
nit: mktemp above will actually create the directory, so this is not necessary (although harmless because of the '-p').
http://gerrit.cloudera.org:8080/#/c/15735/6/bin/jenkins/populate_m2_directory.py
File bin/jenkins/populate_m2_directory.py:
http://gerrit.cloudera.org:8080/#/c/15735/6/bin/jenkins/populate_m2_directory.py@25
PS6, Line 25: ALL_BUILD_OPTIONS_JOB = "all-build-options-ub1604"
The script would gain some flexibility if these constants were exposed as parameters with default values; but that's OK to happen in a subsequent commit.
--
To view, visit http://gerrit.cloudera.org:8080/15735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5065658d8c0514550927161855b0943fa7b3a402
Gerrit-Change-Number: 15735
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jun 2020 16:19:16 +0000
Gerrit-HasComments: Yes