You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Christian Lavoie (JIRA)" <ji...@apache.org> on 2010/09/28 03:21:32 UTC
[jira] Created: (THRIFT-932) Haskell tests need to be run through
'make check' (and probably 'cabal check') too
Haskell tests need to be run through 'make check' (and probably 'cabal check') too
----------------------------------------------------------------------------------
Key: THRIFT-932
URL: https://issues.apache.org/jira/browse/THRIFT-932
Project: Thrift
Issue Type: Bug
Components: Haskell - Library
Affects Versions: 0.6
Environment: Mac OS X 10.6, latest haskell platform, ghc 6.12.3
Darwin 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
The Glorious Glasgow Haskell Compilation System, version 6.12.3
Reporter: Christian Lavoie
Assignee: Christian Lavoie
Fix For: 0.6
Currently Haskell tests are run through an annoying pair of shell scripts, and leave the server running after being executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-932) Haskell tests need to be run through
'make check' (and probably 'cabal check') too
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lavoie updated THRIFT-932:
------------------------------------
Attachment: v1-simplify-haskell-tests.hs
out
This fix a few annoyances with the current tests:
# Two scripts to run to run the tests
# The server bits are left running and need to be Ctrl-C'ed
# Specifying where to find the {{thrift}} binary THRIFT_BIN is needed (or the code needs to be compiled and installed first, so that it's in your path)
After this patch, tests can be run thusly:
{noformat}
$ for TEST in ConstantsDemo DebugProtoTest ThriftTest ; do echo -------------------------------- $TEST -------------------------------- ; ./run-test.sh $TEST; done >& out
{noformat}
See 'out' file for a sample output; not pretty, but works.
This could be committed as is (I could even be convinced it's good enough for 0.5), but is NOT enough to fix this bug.
> Haskell tests need to be run through 'make check' (and probably 'cabal check') too
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-932
> URL: https://issues.apache.org/jira/browse/THRIFT-932
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 0.6
> Environment: Mac OS X 10.6, latest haskell platform, ghc 6.12.3
> Darwin 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Fix For: 0.6
>
> Attachments: out, v1-simplify-haskell-tests.hs
>
>
> Currently Haskell tests are run through an annoying pair of shell scripts, and leave the server running after being executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-932) Haskell tests need to be run through
'make check' (and probably 'cabal check') too
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lavoie updated THRIFT-932:
------------------------------------
Attachment: haskell-tests.log
v3-haskell-tests-through-make-check.patch
Superset of v2 patch -- this has all the same features as v2, and as a bonus hooks both {{cabal check}} and running the tests to {{make check}}.
> Haskell tests need to be run through 'make check' (and probably 'cabal check') too
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-932
> URL: https://issues.apache.org/jira/browse/THRIFT-932
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 0.6
> Environment: Mac OS X 10.6, latest haskell platform, ghc 6.12.3
> Darwin 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Fix For: 0.6
>
> Attachments: haskell-tests.log, out, v1-simplify-haskell-tests.hs, v2-simplify-haskell-tests.patch, v3-haskell-tests-through-make-check.patch
>
>
> Currently Haskell tests are run through an annoying pair of shell scripts, and leave the server running after being executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-932) Haskell tests need to be run through
'make check' (and probably 'cabal check') too
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lavoie updated THRIFT-932:
------------------------------------
Attachment: v2-simplify-haskell-tests.patch
Same as v1, re-synced to HEAD. Apply with {{patch -p0 -E}}.
As it stands, it doesn't fix this bug, but it's self-contained and makes it much easier to run haskell tests. It's a great first step; next steps ought to be simple mucking around with autotools. Before:
# run/helper scripts don't give useful info when reporting 'user errors'
# Tests are split in two: Server, Client. The server needs to be started first, and is then left running after tests
After:
# Tests are combined/self-contained (each test is a process talking to itself through a TCP socket) that correctly exits after running
# There's a single run script
# run script has improved error messages
# run script defaults to the thrift binary compiled in the current source directory instead of those in PATH
> Haskell tests need to be run through 'make check' (and probably 'cabal check') too
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-932
> URL: https://issues.apache.org/jira/browse/THRIFT-932
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 0.6
> Environment: Mac OS X 10.6, latest haskell platform, ghc 6.12.3
> Darwin 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Fix For: 0.6
>
> Attachments: out, v1-simplify-haskell-tests.hs, v2-simplify-haskell-tests.patch
>
>
> Currently Haskell tests are run through an annoying pair of shell scripts, and leave the server running after being executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-932) Haskell tests need to be run through
'make check' (and probably 'cabal check') too
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918328#action_12918328 ]
Christian Lavoie commented on THRIFT-932:
-----------------------------------------
It works for me, and v3 is a full resolution of the bug.
The only caveat is the dependency on the {{http}}, {{binary}} and {{network}} packages that aren't part of the std install; but if you can make it work on your machine, do please commit, yes. Easiest path to making it work:
{noformat}
sudo cabal install http binary network
cd $REPOS
./configure
make check
{noformat}
If you don't like using root powers:
{noformat}
cabal --user install http binary network
cd $REPOS
CABAL_CONFIGURE_FLAGS="--user" ./configure
make check
{noformat}
> Haskell tests need to be run through 'make check' (and probably 'cabal check') too
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-932
> URL: https://issues.apache.org/jira/browse/THRIFT-932
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 0.6
> Environment: Mac OS X 10.6, latest haskell platform, ghc 6.12.3
> Darwin 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Fix For: 0.6
>
> Attachments: haskell-tests.log, out, v1-simplify-haskell-tests.hs, v2-simplify-haskell-tests.patch, v3-haskell-tests-through-make-check.patch
>
>
> Currently Haskell tests are run through an annoying pair of shell scripts, and leave the server running after being executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-932) Haskell tests need to be run through
'make check' (and probably 'cabal check') too
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918324#action_12918324 ]
Bryan Duxbury commented on THRIFT-932:
--------------------------------------
Feel like this is ready to be commmitted?
> Haskell tests need to be run through 'make check' (and probably 'cabal check') too
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-932
> URL: https://issues.apache.org/jira/browse/THRIFT-932
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 0.6
> Environment: Mac OS X 10.6, latest haskell platform, ghc 6.12.3
> Darwin 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Fix For: 0.6
>
> Attachments: haskell-tests.log, out, v1-simplify-haskell-tests.hs, v2-simplify-haskell-tests.patch, v3-haskell-tests-through-make-check.patch
>
>
> Currently Haskell tests are run through an annoying pair of shell scripts, and leave the server running after being executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-932) Haskell tests need to be run through
'make check' (and probably 'cabal check') too
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-932.
--------------------------------
Resolution: Fixed
I just committed this. Thanks for the patch, Christian!
> Haskell tests need to be run through 'make check' (and probably 'cabal check') too
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-932
> URL: https://issues.apache.org/jira/browse/THRIFT-932
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Library
> Affects Versions: 0.6
> Environment: Mac OS X 10.6, latest haskell platform, ghc 6.12.3
> Darwin 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Fix For: 0.6
>
> Attachments: haskell-tests.log, out, v1-simplify-haskell-tests.hs, v2-simplify-haskell-tests.patch, v3-haskell-tests-through-make-check.patch
>
>
> Currently Haskell tests are run through an annoying pair of shell scripts, and leave the server running after being executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.