You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2026/06/27 13:58:04 UTC
(commons-collections) 01/03: Reduce copy-pasta in tests.
This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
commit d64768f4ea849e1ce6fc422e571abfa3a72f2f87
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jun 27 13:51:12 2026 +0000
Reduce copy-pasta in tests.
---
.../collections4/collection/AbstractCollectionTest.java | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java b/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
index 349c6fac6..9e67ff123 100644
--- a/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
+++ b/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
@@ -1283,14 +1283,7 @@ public abstract class AbstractCollectionTest<E> extends AbstractObjectTest {
public void testSerializeDeserializeThenCompare() throws Exception {
Object obj = makeObject();
if (obj instanceof Serializable && isTestSerialization()) {
- final ByteArrayOutputStream buffer = new ByteArrayOutputStream();
- final ObjectOutputStream out = new ObjectOutputStream(buffer);
- out.writeObject(obj);
- out.close();
-
- final ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(buffer.toByteArray()));
- final Object dest = in.readObject();
- in.close();
+ final Object dest = serializeDeserialize(obj);
if (isEqualsCheckable()) {
assertEquals(obj, dest, "obj != deserialize(serialize(obj)) - EMPTY Collection");
}
@@ -1301,7 +1294,6 @@ public abstract class AbstractCollectionTest<E> extends AbstractObjectTest {
final ObjectOutputStream out = new ObjectOutputStream(buffer);
out.writeObject(obj);
out.close();
-
final ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(buffer.toByteArray()));
final Object dest = in.readObject();
in.close();