[GitHub] [metron] nickwallen commented on a change in pull request #1383: METRON-1788 Batch profiler pull profile information from zookeeper

[GitBox <gi...@apache.org>]

nickwallen commented on a change in pull request #1383: METRON-1788 Batch profiler pull profile information from zookeeper
URL: https://github.com/apache/metron/pull/1383#discussion_r276253428
 
 

 ##########
 File path: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/cli/BatchProfilerCLIOptions.java
 ##########
 @@ -34,10 +35,22 @@
  * Profiler.
  */
 public enum BatchProfilerCLIOptions {
+  PROFILE_ZK(() -> {
+    Option o = new Option("z", "zookeeper", true, "Zookeeper quorum for profile definitions");
+    o.setRequired(false);
+    return o;
+  }),
+
+  PROFILE_TIMESTAMP_FLD(() -> {
+    Option o = new Option("t", "timestampfield", true,
+            "When pulling profile definitions from zookeeper, the name of a field to source event time from is required");
 
 Review comment:
   This is not exactly true.  If I have a profile defined in Zk that is already using event time (has the `timestampField` defined, then I should not have to define `--timestampField` on the command line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services