[GitHub] [hive] marton-bod commented on a change in pull request #2298: HIVE-25139: Filter out null table properties in HiveIcebergMetaHook

[GitBox <gi...@apache.org>]

marton-bod commented on a change in pull request #2298:
URL: https://github.com/apache/hive/pull/2298#discussion_r635934956



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -297,6 +297,9 @@ private void updateHmsTableProperties(org.apache.hadoop.hive.metastore.api.Table
           "Table location not set");
     }
 
+    // Remove null values from hms table properties
+    hmsTable.getParameters().entrySet().removeIf(e -> e.getValue() == null);

Review comment:
       Do we need to remove null keys here too, just like in `getCatalogProperties`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org