You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by th...@apache.org on 2013/09/14 00:27:19 UTC
svn commit: r1523130 - in /hive/trunk/hcatalog/webhcat/svr/src/main: config/
java/org/apache/hive/hcatalog/templeton/
java/org/apache/hive/hcatalog/templeton/tool/
Author: thejas
Date: Fri Sep 13 22:27:18 2013
New Revision: 1523130
URL: http://svn.apache.org/r1523130
Log:
HIVE-5241: Default log4j log level for WebHCat should be INFO not DEBUG (Eugene Koifman via Thejas Nair)
Modified:
hive/trunk/hcatalog/webhcat/svr/src/main/config/webhcat-log4j.properties
hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java
hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java
hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Server.java
hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/HDFSStorage.java
Modified: hive/trunk/hcatalog/webhcat/svr/src/main/config/webhcat-log4j.properties
URL: http://svn.apache.org/viewvc/hive/trunk/hcatalog/webhcat/svr/src/main/config/webhcat-log4j.properties?rev=1523130&r1=1523129&r2=1523130&view=diff
==============================================================================
--- hive/trunk/hcatalog/webhcat/svr/src/main/config/webhcat-log4j.properties (original)
+++ hive/trunk/hcatalog/webhcat/svr/src/main/config/webhcat-log4j.properties Fri Sep 13 22:27:18 2013
@@ -16,7 +16,7 @@
# under the License.
# Define some default values that can be overridden by system properties
-webhcat.root.logger = DEBUG, standard
+webhcat.root.logger = INFO, standard
webhcat.log.dir = .
webhcat.log.file = webhcat.log
Modified: hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java
URL: http://svn.apache.org/viewvc/hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java?rev=1523130&r1=1523129&r2=1523130&view=diff
==============================================================================
--- hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java (original)
+++ hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java Fri Sep 13 22:27:18 2013
@@ -158,7 +158,7 @@ public class AppConfig extends Configura
File f = new File(dir, fname);
if (f.exists()) {
addResource(new Path(f.getAbsolutePath()));
- LOG.debug("loaded config file " + f.getAbsolutePath());
+ LOG.info("loaded config file " + f.getAbsolutePath());
return true;
}
}
Modified: hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java
URL: http://svn.apache.org/viewvc/hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java?rev=1523130&r1=1523129&r2=1523130&view=diff
==============================================================================
--- hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java (original)
+++ hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/CompleteDelegator.java Fri Sep 13 22:27:18 2013
@@ -60,12 +60,12 @@ public class CompleteDelegator extends T
try {
state = new JobState(id, Main.getAppConfigInstance());
if (state.getCompleteStatus() == null)
- failed("Job not yet complete", null);
+ failed("Job not yet complete. jobId=" + id, null);
Long notified = state.getNotifiedTime();
if (notified != null)
- return acceptWithError("Callback already run on "
- + new Date(notified.longValue()));
+ return acceptWithError("Callback already run for jobId=" + id +
+ " at " + new Date(notified));
String callback = state.getCallback();
if (callback == null)
Modified: hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Server.java
URL: http://svn.apache.org/viewvc/hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Server.java?rev=1523130&r1=1523129&r2=1523130&view=diff
==============================================================================
--- hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Server.java (original)
+++ hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/Server.java Fri Sep 13 22:27:18 2013
@@ -727,7 +727,7 @@ public class Server {
}
/**
- * Notify on a completed job.
+ * Notify on a completed job. Called by JobTracker.
*/
@GET
@Path("internal/complete/{jobid}")
Modified: hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/HDFSStorage.java
URL: http://svn.apache.org/viewvc/hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/HDFSStorage.java?rev=1523130&r1=1523129&r2=1523130&view=diff
==============================================================================
--- hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/HDFSStorage.java (original)
+++ hive/trunk/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/HDFSStorage.java Fri Sep 13 22:27:18 2013
@@ -102,7 +102,9 @@ public class HDFSStorage implements Temp
}
return val;
} catch (Exception e) {
- LOG.info("Couldn't find " + p + ": " + e.getMessage(), e);
+ //don't print stack trace since clients poll for 'exitValue', 'completed',
+ //files which are not there until job completes
+ LOG.info("Couldn't find " + p + ": " + e.getMessage());
} finally {
close(in);
}