You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2026/09/14 16:52:31 UTC

[PR] ci: reduce workflow overhead [iceberg-rust]

kevinjqliu opened a new pull request, #3221:
URL: https://github.com/apache/iceberg-rust/pull/3221

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   N/A. Follows the [Python repository's workflow-overhead improvements](https://redirect.github.com/apache/iceberg-python/pull/3962).
   
   ## What changes are included in this PR?
   
   <!--
   Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
   -->
   
   - Increase merge-queue build concurrency from 1 to 2, keeping single-PR merges and all other queue settings unchanged.
   - Add concurrency cancellation to CodeQL, zizmor, and ASF Allowlist Check. Groups are scoped by workflow, ref, and event so separate merge-group runs remain independent.
   - Move ASF Allowlist Check, stale maintenance, and the nightly Python release's timestamp job to `ubuntu-slim`, without adding setup steps.
   
   Keep `main` cache-hydration runs and existing build/test runners unchanged.
   
   ## Are these changes tested?
   
   <!--
   Specify what test covers (unit test, integration test, etc.).
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   - `actionlint` passes for the edited allowlist, CodeQL, stale, and zizmor workflows.
   - The nightly workflow has the same pre-existing `actionlint` diagnostics as the base revision (`$/` local-action references and SC2086); its only change is the timestamp job's runner label.
   - `git diff --check` passes. Confirmed the only ASF configuration change is build concurrency from 1 to 2.
   
   Workflow/configuration-only changes; no Rust tests run. CI results were not awaited.
   
   ## AI Disclosure
   
   <!--
   https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions
   -->
   
   Implemented with GitHub Copilot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] ci: reduce workflow overhead [iceberg-rust]

Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on code in PR #3221:
URL: https://github.com/apache/iceberg-rust/pull/3221#discussion_r4007539191


##########
.github/workflows/asf-allowlist-check.yml:
##########
@@ -27,12 +27,16 @@ on:
   pull_request:
   merge_group:
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+  cancel-in-progress: true

Review Comment:
   Do we really see multiple runs sharing the same ref and event?
   
   What's the trigger?



##########
.asf.yaml:
##########
@@ -73,7 +73,7 @@ github:
           parameters:
             check_response_timeout_minutes: 90
             grouping_strategy: ALLGREEN
-            max_entries_to_build: 1
+            max_entries_to_build: 2

Review Comment:
   I'm not against more, conflicts are rare-ish.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] ci: shorten the slowest CI jobs [iceberg-rust]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed pull request #3221: ci: shorten the slowest CI jobs
URL: https://github.com/apache/iceberg-rust/pull/3221


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] ci: reduce workflow overhead [iceberg-rust]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3221:
URL: https://github.com/apache/iceberg-rust/pull/3221#issuecomment-6181453673

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] ci: shorten the slowest CI jobs [iceberg-rust]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #3221:
URL: https://github.com/apache/iceberg-rust/pull/3221#issuecomment-6379821197

   abandoning this for now, its not a big enough improvement to ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org