You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zwy991114 (via GitHub)" <gi...@apache.org> on 2026/04/23 06:30:53 UTC
[PR] [fix](serde) Escape special characters in STRUCT/MAP/ARRAY string fie… [doris]
zwy991114 opened a new pull request, #62741:
URL: https://github.com/apache/doris/pull/62741
### What problem does this PR solve?
Issue Number: close #61119
Related PR: #xxx
Problem Summary:
When querying STRUCT/MAP/ARRAY columns containing strings with special characters (double quotes, backslashes, newlines, tabs), Doris was outputting invalid JSON format.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT/MAP/ARRAY string fie… [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4302630919
# BE UT Coverage Report
Increment line coverage `77.78% (7/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/efd9007a812be88a3958e49987f69256283934f0_efd9007a812be88a3958e49987f69256283934f0/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/efd9007a812be88a3958e49987f69256283934f0_efd9007a812be88a3958e49987f69256283934f0/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.33% (20367/38193) |
| Line Coverage | 36.87% (191923/520520) |
| Region Coverage | 33.19% (149247/449703) |
| Branch Coverage | 34.30% (65277/190338) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62741:
URL: https://github.com/apache/doris/pull/62741#discussion_r3145202724
##########
be/src/core/data_type_serde/data_type_struct_serde.cpp:
##########
@@ -587,14 +587,20 @@ Status DataTypeStructSerDe::from_string_strict_mode(StringRef& str, IColumn& col
void DataTypeStructSerDe::to_string(const IColumn& column, size_t row_num, BufferWritable& bw,
const DataTypeSerDe::FormatOptions& options) const {
const auto& struct_column = assert_cast<const ColumnStruct&>(column);
+
+ // Enable JSON escaping for nested strings in STRUCT
+ FormatOptions struct_options = options;
+ struct_options.escape_char = '\\';
Review Comment:
This only turns on escaping for `STRUCT::to_string()`, but the user-facing text path for top-level `ARRAY` and `MAP` still goes through `DataTypeArraySerDe::to_string()` / `DataTypeMapSerDe::to_string()` with `escape_char == 0` from `VMysqlResultWriter` and `CastToString`. So `SELECT array('"a"', '"b"')` still renders as `[""a"", ""b""]` (you can still see that in the updated `test_query_json_insert.out` golden), which means the PR does not actually fix the stated `STRUCT/MAP/ARRAY` scope yet. Please either enable escaping for the parallel array/map text serializers too, or set the flag once at the top-level DORIS text-output entry point so every nested string path is covered consistently.
##########
regression-test/suites/query_p0/sql_functions/struct_functions/test_struct_special_chars.groovy:
##########
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_struct_special_chars") {
+ def tableName = "t_struct_special_chars"
+
+ sql "DROP TABLE IF EXISTS ${tableName}"
+ sql """
+ CREATE TABLE ${tableName} (
+ pk INT,
+ st STRUCT<a: STRING>
+ ) PROPERTIES ("replication_num" = "1")
+ """
+
+ // Insert string with double quotes
+ sql """INSERT INTO ${tableName}(pk, st) VALUES (1, STRUCT('"aa"'))"""
+
+ // Direct SELECT should output valid JSON with escaped quotes
+ qt_select_struct_quotes """SELECT st FROM ${tableName} WHERE pk = 1"""
Review Comment:
Issue #61119 and the PR description both call out `STRUCT/MAP/ARRAY`, but this new regression only exercises `STRUCT`. Since array/map use parallel text-serialization paths, this suite does not prove the full fix or catch the still-broken array/map cases. Please add array<string> / map<string,string> cases with quotes, backslashes, newlines, and tabs here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4305664698
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (13/13)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62741_7617e262718c7f3d2567d81cc5c6ddf7f754d2df_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62741_7617e262718c7f3d2567d81cc5c6ddf7f754d2df_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.40% (26726/37433) |
| Line Coverage | 53.77% (279258/519350) |
| Region Coverage | 47.10% (214527/455462) |
| Branch Coverage | 50.43% (97167/192671) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4313617211
OpenCode automated review failed and did not complete.
Error: Review step was failure (possibly timeout or cancelled)
Workflow run: https://github.com/apache/doris/actions/runs/24887672922
Please inspect the workflow logs and rerun the review after the underlying issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT/MAP/ARRAY string fie… [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4303260079
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (9/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62741_efd9007a812be88a3958e49987f69256283934f0_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62741_efd9007a812be88a3958e49987f69256283934f0_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.50% (27503/37418) |
| Line Coverage | 57.30% (297498/519225) |
| Region Coverage | 54.67% (248231/454029) |
| Branch Coverage | 56.14% (107260/191068) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4324506267
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4313587866
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (13/13)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62741_7eca4bc2448acce38ce52a04219801523d9989a3_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62741_7eca4bc2448acce38ce52a04219801523d9989a3_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.46% (26793/37494) |
| Line Coverage | 53.85% (279946/519866) |
| Region Coverage | 47.21% (215246/455969) |
| Branch Coverage | 50.52% (97451/192881) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4323958496
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on code in PR #62741:
URL: https://github.com/apache/doris/pull/62741#discussion_r3159026457
##########
regression-test/data/query_p0/sql_functions/json_function/test_query_json_insert.out:
##########
@@ -64,7 +64,7 @@
-- !sql4 --
1 \N \N \N \N
2 ["a", "b"] {"name":"a", "age":1} {"a":"b"} $[0]
-3 [""a"", ""b""] {"name":""a"", "age":1} {"c":"d"} $.*.array
+3 [""a"", ""b""] {"name":"\"a\"", "age":1} {"c":"d"} $.*.array
Review Comment:
不确定其他类型，所以只调整了struct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4313349974
# BE UT Coverage Report
Increment line coverage `84.62% (11/13)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7eca4bc2448acce38ce52a04219801523d9989a3_7eca4bc2448acce38ce52a04219801523d9989a3/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7eca4bc2448acce38ce52a04219801523d9989a3_7eca4bc2448acce38ce52a04219801523d9989a3/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.33% (20401/38255) |
| Line Coverage | 36.87% (192189/521255) |
| Region Coverage | 33.18% (149446/450456) |
| Branch Coverage | 34.30% (65399/190652) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on code in PR #62741:
URL: https://github.com/apache/doris/pull/62741#discussion_r3158542334
##########
regression-test/data/query_p0/sql_functions/json_function/test_query_json_insert.out:
##########
@@ -64,7 +64,7 @@
-- !sql4 --
1 \N \N \N \N
2 ["a", "b"] {"name":"a", "age":1} {"a":"b"} $[0]
-3 [""a"", ""b""] {"name":""a"", "age":1} {"c":"d"} $.*.array
+3 [""a"", ""b""] {"name":"\"a\"", "age":1} {"c":"d"} $.*.array
Review Comment:
那为什么只有 struct 需要是"\"a\""，[""a"", ""b""] array这个不需要吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #62741: [fix](serde) Escape special characters in STRUCT string fields (#61119)
URL: https://github.com/apache/doris/pull/62741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT/MAP/ARRAY string fie… [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4302208361
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT/MAP/ARRAY string fie… [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4304748197
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62741:
URL: https://github.com/apache/doris/pull/62741#discussion_r3145447407
##########
be/src/core/data_type_serde/data_type_string_serde.cpp:
##########
@@ -430,7 +430,17 @@ void DataTypeStringSerDeBase<ColumnType>::to_string(const IColumn& column, size_
const auto& value =
assert_cast<const ColumnType&, TypeCheckOnRelease::DISABLE>(column).get_data_at(
row_num);
- bw.write(value.data, value.size);
+
+ if constexpr (std::is_same_v<ColumnType, ColumnString>) {
+ if (_nesting_level > 1 && options.escape_char != 0) {
Review Comment:
This branch now makes `SELECT struct_col` / `CAST(struct_col AS STRING)` emit JSON escapes for `\n`, `\t`, `\r`, `\b`, and `\f`, but the reverse parser still does not decode those escapes. `cast_from_string_to_complex_type()` passes `escape_char='\\'`, and `DataTypeStringSerDeBase::deserialize_one_cell_from_json()` just strips the backslash via `escape_string()` instead of translating `\n` back to a newline byte. As a result, `CAST(CAST(st AS STRING) AS STRUCT<a:STRING>)` now round-trips `a\nb\tc` as `anbtc`. Please either teach the string parser to decode standard JSON escapes or avoid emitting them on this path until the reverse direction is fixed.
##########
be/src/core/data_type_serde/data_type_string_serde.cpp:
##########
@@ -430,7 +430,17 @@ void DataTypeStringSerDeBase<ColumnType>::to_string(const IColumn& column, size_
const auto& value =
assert_cast<const ColumnType&, TypeCheckOnRelease::DISABLE>(column).get_data_at(
row_num);
- bw.write(value.data, value.size);
+
+ if constexpr (std::is_same_v<ColumnType, ColumnString>) {
+ if (_nesting_level > 1 && options.escape_char != 0) {
+ write_with_escaped_char_to_json(value, bw);
Review Comment:
This still does not make the struct text output valid JSON for all strings. `write_with_escaped_char_to_json()` only handles `\"`, `\\`, `\b`, `\f`, `\n`, `\r`, and `\t`; bytes like `0x00`, `0x01`, or `0x1B` are written raw inside the quoted string. JSON requires every `U+0000..U+001F` control byte to be escaped, so a struct field containing those bytes will still produce invalid JSON on the new path. Please switch to a full JSON string escaper (or add `\u00XX` escaping for the remaining control bytes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4341437183
> 原始的issues问题是我们的struct的输出不是一个合法的json？ 可是问题是我们也没有说过我们的输出是合法的json？ 可能他需要把struct cast 成json来满足他的需求？
是的，cast目前可以满足
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT/MAP/ARRAY string fie… [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4302196751
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4305602362
# BE UT Coverage Report
Increment line coverage `84.62% (11/13)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7617e262718c7f3d2567d81cc5c6ddf7f754d2df_7617e262718c7f3d2567d81cc5c6ddf7f754d2df/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7617e262718c7f3d2567d81cc5c6ddf7f754d2df_7617e262718c7f3d2567d81cc5c6ddf7f754d2df/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.33% (20370/38194) |
| Line Coverage | 36.88% (192071/520739) |
| Region Coverage | 33.23% (149538/449982) |
| Branch Coverage | 34.32% (65360/190458) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4312863198
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4312861076
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "zwy991114 (via GitHub)" <gi...@apache.org>.
zwy991114 commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4324793442
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4324336150
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (13/13)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62741_7eca4bc2448acce38ce52a04219801523d9989a3_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62741_7eca4bc2448acce38ce52a04219801523d9989a3_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.47% (26798/37494) |
| Line Coverage | 53.87% (280041/519866) |
| Region Coverage | 47.23% (215339/455969) |
| Branch Coverage | 50.55% (97495/192881) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](serde) Escape special characters in STRUCT string fields (#61119) [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62741:
URL: https://github.com/apache/doris/pull/62741#issuecomment-4340760965
原始的issues问题是我们的struct的输出不是一个合法的json？
可是问题是我们也没有说过我们的输出是合法的json？
可能他需要把struct cast 成json来满足他的需求？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org