[GitHub] [kafka] cadonna commented on a diff in pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

[GitBox <gi...@apache.org>]

cadonna commented on code in PR #12285:
URL: https://github.com/apache/kafka/pull/12285#discussion_r925333066


##########
streams/src/test/java/org/apache/kafka/streams/integration/ErrorHandlingIntegrationTest.java:
##########
@@ -52,36 +52,46 @@
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.MatcherAssert.assertThat;
 
+@Timeout(600)
 @Category(IntegrationTest.class)
 public class ErrorHandlingIntegrationTest {
 
+    private final String testId;
+    private final String appId;
+    private final Properties properties;
+
+    // Task 0
+    private final String inputTopic;
+    private final String outputTopic;
+    // Task 1
+    private final String errorInputTopic;
+    private final String errorOutputTopic;
+
     private static final EmbeddedKafkaCluster CLUSTER = new EmbeddedKafkaCluster(1);
 
-    @BeforeClass
+    ErrorHandlingIntegrationTest(final TestInfo testInfo) {
+        testId = safeUniqueTestName(getClass(), testInfo);
+        appId = "appId_" + testId;
+        properties = props();
+
+        inputTopic = "input" + testId;
+        outputTopic = "output" + testId;
+
+        errorInputTopic = "error-input" + testId;
+        errorOutputTopic = "error-output" + testId;
+    }

Review Comment:
   Why did you not put this code into the `setup()` method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org