[GitHub] [jackrabbit-oak] sdmcraft commented on a diff in pull request #868: OAK-10136: DynamicBoostLite tags should have less relevance than other fields

["sdmcraft (via GitHub)" <gi...@apache.org>]

sdmcraft commented on code in PR #868:
URL: https://github.com/apache/jackrabbit-oak/pull/868#discussion_r1130983314


##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java:
##########
@@ -1545,6 +1545,8 @@ private static Query tokenToQuery(String text, String fieldName, PlanResult pr,
             Query subQuery = new BooleanQuery();
             if (pr.indexDefinition.isDynamicBoostLiteEnabled()) {
                 subQuery = tokenToQuery(text, FieldNames.SIMILARITY_TAGS, analyzer);
+                // De-boosting dynamic boost based query so other clauses will have more relevance
+                subQuery.setBoost(0.001f);

Review Comment:
   This used to be 0.0001f I think. [0]
   
   [0] - https://git.corp.adobe.com/CQ/dam/blob/a4173e7086e399a40f0985df252bf6a80bc29fad/bundles/similarity-search/src/main/java/com/day/cq/dam/similaritysearch/internal/impl/ManageAutoTagsServiceImpl.java#L534-L535



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org