You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/12/24 00:38:24 UTC
[GitHub] [lucene-solr] megancarey opened a new pull request #1117: Jira/solr
13101 precommit fixes
megancarey opened a new pull request #1117: Jira/solr 13101 precommit fixes
URL: https://github.com/apache/lucene-solr/pull/1117
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This PR is just to fix precommit errors.
# Solution
Added licenses, updated code to remove forbidden method calls, and fixed other miscellaneous issues.
# Tests
N/A - I ran existing tests for the files changed to ensure no change in functionality.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [x] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] yonik merged pull request #1117: SOLR-13101: ant
precommit fixes
Posted by GitBox <gi...@apache.org>.
yonik merged pull request #1117: SOLR-13101: ant precommit fixes
URL: https://github.com/apache/lucene-solr/pull/1117
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] andyvuong commented on a change in pull request
#1117: SOLR-13101: ant precommit fixes
Posted by GitBox <gi...@apache.org>.
andyvuong commented on a change in pull request #1117: SOLR-13101: ant precommit fixes
URL: https://github.com/apache/lucene-solr/pull/1117#discussion_r361501107
##########
File path: solr/core/src/java/org/apache/solr/store/blob/client/LocalStorageClient.java
##########
@@ -97,7 +117,7 @@ public void pushCoreMetadata(String sharedStoreName, String blobCoreMetadataName
// Writing to the file assumed atomic, the file cannot be observed midway. Might not hold here but should be the case
// with a real S3 implementation.
- try (PrintWriter out = new PrintWriter(blobMetadataFile)){
+ try (PrintWriter out = new PrintWriter(blobMetadataFile, StandardCharsets.UTF_8.name())){
Review comment:
This only affects core.metadata and not all blob files btw - local storage client is only used for testing purposes so this is fine here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] megancarey commented on a change in pull request
#1117: SOLR-13101: ant precommit fixes
Posted by GitBox <gi...@apache.org>.
megancarey commented on a change in pull request #1117: SOLR-13101: ant precommit fixes
URL: https://github.com/apache/lucene-solr/pull/1117#discussion_r361037691
##########
File path: solr/core/src/java/org/apache/solr/store/blob/client/LocalStorageClient.java
##########
@@ -97,7 +117,7 @@ public void pushCoreMetadata(String sharedStoreName, String blobCoreMetadataName
// Writing to the file assumed atomic, the file cannot be observed midway. Might not hold here but should be the case
// with a real S3 implementation.
- try (PrintWriter out = new PrintWriter(blobMetadataFile)){
+ try (PrintWriter out = new PrintWriter(blobMetadataFile, StandardCharsets.UTF_8.name())){
Review comment:
@andyvuong I've made an assumption here that all of our blob files are UTF-8 encoded, is that a valid assumption? We need to specify a charset to decode in several places
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org