You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/05/28 05:38:27 UTC
[GitHub] [carbondata] ravipesala commented on a change in pull request
#3237: [CARBONDATA-3399] Implement excutor id based distribution for
indexserver
ravipesala commented on a change in pull request #3237: [CARBONDATA-3399] Implement excutor id based distribution for indexserver
URL: https://github.com/apache/carbondata/pull/3237#discussion_r287935844
##########
File path: integration/spark2/src/main/scala/org/apache/carbondata/indexserver/DistributedPruneRDD.scala
##########
@@ -49,7 +49,8 @@ private[indexserver] class DistributedPruneRDD(@transient private val ss: SparkS
dataMapFormat: DistributableDataMapFormat)
extends CarbonRDD[(String, ExtendedBlocklet)](ss, Nil) {
- val executorsList: Set[String] = DistributionUtil.getNodeList(ss.sparkContext).toSet
+ @transient val executorsList: Map[String, Seq[String]] = DistributionUtil
Review comment:
I don't think it is required to keep at class level, better move it to method level as you are using at one place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services