You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2011/05/01 03:01:15 UTC

[jira] [Updated] (WICKET-3649) ClassCastException when AbstractResource writes in response of some type other than WebResponse

     [ https://issues.apache.org/jira/browse/WICKET-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pedro Santos updated WICKET-3649:
---------------------------------

    Attachment: WICKET-3649-refactoring-fix-test.patch

Same fix; moving header setup code to ResourceResponse and test case preventing the bug.

IMO AbtratctResource is just an API to handler objects and all response setup code makes more sense inside ResourceResponse. The attached patch do not move caching headers setup to it since this change would involve API break.

> ClassCastException when AbstractResource writes in response of some type other than WebResponse
> -----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3649
>                 URL: https://issues.apache.org/jira/browse/WICKET-3649
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Pedro Santos
>            Assignee: Pedro Santos
>         Attachments: WICKET-3649-refactoring-fix-test.patch, WICKET-3649.patch
>
>
> Some times is usefull to write the resource in ByteArrayResponse to access the response bytes latter. An use case is ThumbnailImageResource accessing the wrapped resource image to first resize it and than write in response.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira