You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/15 15:38:52 UTC
[GitHub] [shardingsphere] sunkai-cai opened a new pull request, #20206: Refactor parameter definition of DistSQL for feature db-discovery
sunkai-cai opened a new pull request, #20206:
URL: https://github.com/apache/shardingsphere/pull/20206
Fixes #20032.
Changes proposed in this pull request:
- Add parser test cases in module `shardingsphere-db-discovery-distsql`
- Refactor parameter definition of DatabaseDiscoveryDistSQL
1. CREATE DB_DISCOVERY RULE
before:
```
CREATE DB_DISCOVERY RULE db_discovery_group_0 (
RESOURCES(ds_0, ds_1), TYPE(NAME=mgr,PROPERTIES('group-name'='92504d5b')),
HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')));
```
after
```
CREATE DB_DISCOVERY RULE db_discovery_group_0 (
RESOURCES(ds_0, ds_1), TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b')),
HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')));
```
3. ALTER DB_DISCOVERY RULE
before:
```
ALTER DB_DISCOVERY RULE db_discovery_group_0 (
RESOURCES(ds_0, ds_1), TYPE(NAME=mgr,PROPERTIES('group-name'='92504d5b')),
HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')));
```
after:
```
ALTER DB_DISCOVERY RULE db_discovery_group_0 (
RESOURCES(ds_0, ds_1), TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b')),
HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')));
```
5. CREATE DB_DISCOVERY TYPE
before:
```
CREATE DB_DISCOVERY TYPE
primary_replica_ds_mgr(TYPE(NAME=mgr,PROPERTIES('group-name'='92504d5b'))),
primary_replica_ds_mgr_2(TYPE(NAME=mgr));
```
after:
```
CREATE DB_DISCOVERY TYPE
primary_replica_ds_mgr(TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b'))),
primary_replica_ds_mgr_2(TYPE(NAME='mgr'));
```
7. ALTER DB_DISCOVERY TYPE
before:
```
ALTER DB_DISCOVERY TYPE
primary_replica_ds_mgr(TYPE(NAME=mgr,PROPERTIES('group-name'='92504d5b'))),
primary_replica_ds_mgr_2(TYPE(NAME=mgr));
```
after:
```
ALTER DB_DISCOVERY TYPE
primary_replica_ds_mgr(TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b'))),
primary_replica_ds_mgr_2(TYPE(NAME='mgr'));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #20206: Refactor parameter definition of DistSQL for feature db-discovery
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #20206:
URL: https://github.com/apache/shardingsphere/pull/20206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20206: Refactor parameter definition of DistSQL for feature db-discovery
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20206:
URL: https://github.com/apache/shardingsphere/pull/20206#issuecomment-1216240460
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20206?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20206](https://codecov.io/gh/apache/shardingsphere/pull/20206?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcb9e9e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/be5cfc2510a4b285845949b822cc31420d943ffe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be5cfc2) will **increase** coverage by `0.46%`.
> The diff coverage is `62.94%`.
> :exclamation: Current head bcb9e9e differs from pull request most recent head f412cef. Consider uploading reports for the commit f412cef to get more accurate results
```diff
@@ Coverage Diff @@
## master #20206 +/- ##
============================================
+ Coverage 60.54% 61.00% +0.46%
+ Complexity 2422 2421 -1
============================================
Files 3874 3870 -4
Lines 54796 54454 -342
Branches 7679 7617 -62
============================================
+ Hits 33176 33221 +45
+ Misses 18761 18369 -392
- Partials 2859 2864 +5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rror/mysql/mapper/MySQLDialectExceptionMapper.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZXJyb3Ivc2hhcmRpbmdzcGhlcmUtbXlzcWwtZXJyb3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Vycm9yL215c3FsL21hcHBlci9NeVNRTERpYWxlY3RFeGNlcHRpb25NYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...resql/mapper/PostgreSQLDialectExceptionMapper.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZXJyb3Ivc2hhcmRpbmdzcGhlcmUtcG9zdGdyZXNxbC1lcnJvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZXJyb3IvcG9zdGdyZXNxbC9tYXBwZXIvUG9zdGdyZVNRTERpYWxlY3RFeGNlcHRpb25NYXBwZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../dbdiscovery/route/DatabaseDiscoverySQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9yb3V0ZS9EYXRhYmFzZURpc2NvdmVyeVNRTFJvdXRlci5qYXZh) | `95.23% <ø> (ø)` | |
| [...nce/FixedPrimaryReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvRml4ZWRQcmltYXJ5UmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `60.00% <ø> (ø)` | |
| [...ransactionRandomReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25SYW5kb21SZWFkUXVlcnlMb2FkQmFsYW5jZUFsZ29yaXRobS5qYXZh) | `66.66% <ø> (ø)` | |
| [...actionRoundRobinReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25Sb3VuZFJvYmluUmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `66.66% <ø> (ø)` | |
| [...ransactionWeightReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25XZWlnaHRSZWFkUXVlcnlMb2FkQmFsYW5jZUFsZ29yaXRobS5qYXZh) | `69.38% <ø> (ø)` | |
| [...e/shardingsphere/shadow/route/ShadowSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvU2hhZG93U1FMUm91dGVyLmphdmE=) | `33.33% <ø> (ø)` | |
| [...phere/sharding/route/engine/ShardingSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL1NoYXJkaW5nU1FMUm91dGVyLmphdmE=) | `78.94% <ø> (ø)` | |
| [...gine/impl/InsertClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL2NvbmRpdGlvbi9lbmdpbmUvaW1wbC9JbnNlcnRDbGF1c2VTaGFyZGluZ0NvbmRpdGlvbkVuZ2luZS5qYXZh) | `81.81% <ø> (ø)` | |
| ... and [123 more](https://codecov.io/gh/apache/shardingsphere/pull/20206/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #20206: Refactor parameter definition of DistSQL for feature db-discovery
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #20206:
URL: https://github.com/apache/shardingsphere/pull/20206#issuecomment-1216061275
Hi @sunkai-cai
CI failed, you can run `DistSQLParserParameterizedTest` to check it before push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sunkai-cai commented on pull request #20206: Refactor parameter definition of DistSQL for feature db-discovery
Posted by GitBox <gi...@apache.org>.
sunkai-cai commented on PR #20206:
URL: https://github.com/apache/shardingsphere/pull/20206#issuecomment-1216283616
hi @RaigorJiang ，shardingsphere-parser-test fail of CI is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org