You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/09/16 17:27:20 UTC

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4218: [CARBONDATA-4285] Fix alter add complex columns with global sort compaction failure

Indhumathi27 commented on a change in pull request #4218:
URL: https://github.com/apache/carbondata/pull/4218#discussion_r710329999



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
##########
@@ -342,7 +347,12 @@ object DataLoadProcessBuilderOnSpark {
       .mapPartitionsWithIndex { case (index, rows) =>
         ThreadLocalSessionInfo.setConfigurationToCurrentThread(conf.value.value)
         DataLoadProcessorStepOnSpark
-          .convertFunc(rows, index, modelBroadcast, partialSuccessAccum, convertStepRowCounter)
+          .convertFunc(rows,
+            index,
+            modelBroadcast,
+            true,

Review comment:
       this flow looks like load flow. This change might not be needed. can test and remove if not required




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org