You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yamt (via GitHub)" <gi...@apache.org> on 2024/11/08 04:40:12 UTC
[I] [BUG] seemingly wrong up_putc usage in lcd drivers [nuttx]
yamt opened a new issue, #14694:
URL: https://github.com/apache/nuttx/issues/14694
### Description / Steps to reproduce the issue
many lcd drivers have a code fragment like the following:
https://github.com/apache/nuttx/blob/db31e569579c7ec9753d5fb69d07e8f997c7eae1/boards/arm/stm32/stm3240g-eval/src/stm32_lcd.c#L519-L539
(i'm not sure why it's common for lcd drivers. maybe just a result of heavy copy-and-paste?)
it seems like mixing syslog and up_putc, assuming they output to the same console.
of course, the assumption might or might not be correct, depending on the system and configurations.
this isn't a major problem as these code fragments are often wrapped with `#if 0` though.
### On which OS does this issue occur?
[OS: Mac]
### What is the version of your OS?
macOS 14.7
### NuttX Version
master
### Issue Architecture
[Arch: all]
### Issue Area
[Area: Drivers]
### Verification
- [X] I have verified before submitting the report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] seemingly wrong up_putc usage in lcd drivers [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed issue #14694: [BUG] seemingly wrong up_putc usage in lcd drivers
URL: https://github.com/apache/nuttx/issues/14694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] seemingly wrong up_putc usage in lcd drivers [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on issue #14694:
URL: https://github.com/apache/nuttx/issues/14694#issuecomment-2464856077
@yamt good catch, according to git blame these lines were added by @patacongo in 2012 and 2014 respectively, so I think it is not my mistake, should have some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] seemingly wrong up_putc usage in lcd drivers [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed issue #14694: [BUG] seemingly wrong up_putc usage in lcd drivers
URL: https://github.com/apache/nuttx/issues/14694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] seemingly wrong up_putc usage in lcd drivers [nuttx]
Posted by "patacongo (via GitHub)" <gi...@apache.org>.
patacongo commented on issue #14694:
URL: https://github.com/apache/nuttx/issues/14694#issuecomment-2465020835
> @yamt good catch, according to git blame these lines were added by @patacongo in 2012 and 2014 respectively, so I think it is not my mistake, should have some reason.
Its just old debug code that was left in. The xyz_dumprun() functions are not referenced from anywhere in the OS and just be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org