You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/05/19 06:59:47 UTC
[GitHub] [celix] pnoltes opened a new pull request #239: Fixes an incorrect loop that installed bundles multiple times
pnoltes opened a new pull request #239:
URL: https://github.com/apache/celix/pull/239
Fixes an issues where the framework was starting all bundles multiple times for the nr of possible run levels.
The list installedBundles is filled by the autoInstallBundlesForList call and only needs to be loop over once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter edited a comment on pull request #239: Fixes an incorrect loop that installed bundles multiple times
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #239:
URL: https://github.com/apache/celix/pull/239#issuecomment-630626147
# [Codecov](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=h1) Report
> Merging [#239](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f9959d8b5db107d44a144946971c48e6180267d0&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 67.83% 67.88% +0.04%
==========================================
Files 127 127
Lines 26375 26374 -1
==========================================
+ Hits 17891 17903 +12
+ Misses 8484 8471 -13
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libs/framework/src/framework.c](https://codecov.io/gh/apache/celix/pull/239/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `75.50% <100.00%> (+0.19%)` | :arrow_up: |
| [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/239/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `94.23% <0.00%> (+0.86%)` | :arrow_up: |
| [libs/framework/src/celix\_log.c](https://codecov.io/gh/apache/celix/pull/239/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2NlbGl4X2xvZy5j) | `89.06% <0.00%> (+10.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=footer). Last update [f9959d8...8bd235d](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes merged pull request #239: Fixes an incorrect loop that installed bundles multiple times
Posted by GitBox <gi...@apache.org>.
pnoltes merged pull request #239:
URL: https://github.com/apache/celix/pull/239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter commented on pull request #239: Fixes an incorrect loop that installed bundles multiple times
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #239:
URL: https://github.com/apache/celix/pull/239#issuecomment-630626147
# [Codecov](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=h1) Report
> Merging [#239](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=desc) into [master](https://codecov.io/gh/apache/celix/commit/f9959d8b5db107d44a144946971c48e6180267d0&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 67.83% 67.84% +0.01%
==========================================
Files 127 127
Lines 26375 26374 -1
==========================================
+ Hits 17891 17893 +2
+ Misses 8484 8481 -3
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libs/framework/src/framework.c](https://codecov.io/gh/apache/celix/pull/239/diff?src=pr&el=tree#diff-bGlicy9mcmFtZXdvcmsvc3JjL2ZyYW1ld29yay5j) | `75.28% <100.00%> (-0.02%)` | :arrow_down: |
| [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/239/diff?src=pr&el=tree#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `94.23% <0.00%> (+0.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=footer). Last update [f9959d8...8bd235d](https://codecov.io/gh/apache/celix/pull/239?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org