[GitHub] [spark] huaxingao commented on a change in pull request #26057: [SPARK-29377][PYTHON][ML] Parity between Scala ML tuning and Python ML tuning

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #26057: [SPARK-29377][PYTHON][ML] Parity between Scala ML tuning and Python ML tuning
URL: https://github.com/apache/spark/pull/26057#discussion_r334256457
 
 

 ##########
 File path: python/pyspark/ml/tuning.py
 ##########
 @@ -261,19 +260,30 @@ def setParams(self, estimator=None, estimatorParamMaps=None, evaluator=None, num
         kwargs = self._input_kwargs
         return self._set(**kwargs)
 
-    @since("1.4.0")
-    def setNumFolds(self, value):
+    def setEstimator(self, value):
         """
-        Sets the value of :py:attr:`numFolds`.
+        Sets the value of :py:attr:`estimator`.
         """
-        return self._set(numFolds=value)
+        return self._set(estimator=value)
+
+    def setEstimatorParamMaps(self, value):
+        """
+        Sets the value of :py:attr:`estimatorParamMaps`.
+        """
+        return self._set(estimatorParamMaps=value)
+
+    def setEvaluator(self, value):
 
 Review comment:
   If the original file has @since, I have it too. Some of the getters/setters don't have @since in the original file, so I don't have i too.
   I will check the history to find out which release starts to have these getters/setters, and add @since for each of the getters/setters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org