You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/08 09:19:00 UTC

[jira] [Commented] (ARTEMIS-2222) why the position remains unchanged if ignored is set to true

    [ https://issues.apache.org/jira/browse/ARTEMIS-2222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736907#comment-16736907 ] 

ASF GitHub Bot commented on ARTEMIS-2222:
-----------------------------------------

GitHub user CNNJYB opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2492

    ARTEMIS-2222 why the position remains unchanged if ignored is set to true

    I am a bit confused about this, When CursorIterator:next is called during queue depage, if ignored is set to true, why the position remains unchanged. 		
    if (!ignored) {
        position = message.getPosition();
    }		
    For example, the client sends some messages to the topic subscriber ta (this topic has two subscribers ta and tb), every time tb depage continuous PagePositions that ignored are set to true will be traversed again.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CNNJYB/activemq-artemis dev-CursorIterator-moveNext-ignored

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2492
    
----
commit 49f8bcd99640209c825c22e54a32c872850cc000
Author: andytaylor <an...@...>
Date:   2018-10-24T10:21:52Z

    ARTEMIS-2144 - tx begin failure in ra doesn't get cleaned up
    
    https://issues.apache.org/jira/browse/ARTEMIS-2144

commit 7ae39f7d7218e7c5a93eaecb8f24af3d6186e6f3
Author: yb <17...@...>
Date:   2019-01-08T09:14:18Z

    ARTEMIS-2222 why the position remains unchanged if ignored is set to true

----


> why the position remains unchanged if ignored is set to true
> ------------------------------------------------------------
>
>                 Key: ARTEMIS-2222
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2222
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: yuebao
>            Priority: Major
>
> I am a bit confused about this, When CursorIterator:next is called during queue depage, if ignored is set to true, why the position remains unchanged. 
> if (!ignored) {
>  position = message.getPosition();
> } 
> For example, the client sends some messages to the topic subscriber ta (this topic has two subscribers ta and tb), every time tb depage continuous PagePositions that ignored are set to true will be traversed again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)