You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/09/06 03:37:03 UTC
[GitHub] eiri commented on issue #1470: Fix calculation of external size for
attachments
eiri commented on issue #1470: Fix calculation of external size for attachments
URL: https://github.com/apache/couchdb/pull/1470#issuecomment-418953842
@davisp Hey Paul, sorry this took ages to follow up, I kept been distracted by shiny things in Kubernetes land.
It turned out that you right and it's quite possible to have a deleted (with `_deleted` field) doc with attachment, so I removed bits around deleted flag from external size calculation and changed the tests to be more explicit about been ordered.
I also fixed a crash on attempt to restore a doc with attachment and added even more confusing foreachx tests in an attachments tests suite.
Can you please take a look if this looks right to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services