You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "leechor (GitHub)" <gi...@apache.org> on 2019/09/14 14:12:56 UTC
[GitHub] [dubbo] leechor opened pull request #5065: refactor code.
## What is the purpose of the change
make more readability.
## Brief changelog
rearrange and simplity ExtensionLoader and config code, some code rewrite with lambda.
- rearange ExtensionLoader class field layer. rewrite some code fraction with lambda. more readability.
- some comments move to single line.
- rewrite StringUtils.split function in a simple way.
- decrease some _**for**_ and _**if**__ nest layers, more clearly.
- remove some unused code.
[ Full content available at: https://github.com/apache/dubbo/pull/5065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] leechor closed pull request #5065: refactor code.
Posted by "leechor (GitHub)" <gi...@apache.org>.
[ pull request closed by leechor ]
[ Full content available at: https://github.com/apache/dubbo/pull/5065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5065: refactor code.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5065?src=pr&el=h1) Report
> Merging [#5065](https://codecov.io/gh/apache/dubbo/pull/5065?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/60abb6dbae34162556da3bfc1867862458d7981b?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `67.77%`.
[](https://codecov.io/gh/apache/dubbo/pull/5065?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5065 +/- ##
============================================
- Coverage 63.98% 63.93% -0.06%
Complexity 452 452
============================================
Files 769 769
Lines 33206 33187 -19
Branches 5237 5200 -37
============================================
- Hits 21248 21219 -29
- Misses 9533 9546 +13
+ Partials 2425 2422 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/dubbo/cache/filter/CacheFilter.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvZmlsdGVyL0NhY2hlRmlsdGVyLmphdmE=) | `76.19% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/config/spring/util/AnnotationUtils.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9Bbm5vdGF0aW9uVXRpbHMuamF2YQ==) | `39.25% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...java/org/apache/dubbo/common/bytecode/Wrapper.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvV3JhcHBlci5qYXZh) | `82.38% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ArgumentConfig.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Bcmd1bWVudENvbmZpZy5qYXZh) | `94.44% <0%> (-5.56%)` | `0 <0> (ø)` | |
| [...ava/org/apache/dubbo/common/utils/StringUtils.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `84.09% <100%> (-0.3%)` | `0 <0> (ø)` | |
| [...ava/org/apache/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29uZmlnVXRpbHMuamF2YQ==) | `79.85% <100%> (-0.15%)` | `0 <0> (ø)` | |
| [...ain/java/org/apache/dubbo/config/MethodConfig.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9NZXRob2RDb25maWcuamF2YQ==) | `100% <100%> (+1.21%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/rpc/proxy/InvokerInvocationHandler.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm94eS9JbnZva2VySW52b2NhdGlvbkhhbmRsZXIuamF2YQ==) | `53.33% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/common/utils/UrlUtils.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvVXJsVXRpbHMuamF2YQ==) | `78.16% <50%> (+0.12%)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `58.12% <50.58%> (-1.2%)` | `0 <0> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/dubbo/pull/5065/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5065?src=pr&el=footer). Last update [60abb6d...d0c8ded](https://codecov.io/gh/apache/dubbo/pull/5065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] leechor closed pull request #5065: refactor code.
Posted by "leechor (GitHub)" <gi...@apache.org>.
[ pull request closed by leechor ]
[ Full content available at: https://github.com/apache/dubbo/pull/5065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] leechor closed pull request #5065: refactor code.
Posted by "leechor (GitHub)" <gi...@apache.org>.
[ pull request closed by leechor ]
[ Full content available at: https://github.com/apache/dubbo/pull/5065 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org