You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yjshen <gi...@git.apache.org> on 2016/05/18 15:41:35 UTC
[GitHub] flink pull request: [Flink-3926][TypeSystem]Incorrect implementati...
GitHub user yjshen opened a pull request:
https://github.com/apache/flink/pull/2004
[Flink-3926][TypeSystem]Incorrect implementation of getFieldIndex in TupleTypeInfo
The origin code assumes filed name as `f{i}` which is not always true.
Finding a field `a` would result in `NumberFormatException`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yjshen/flink tuple_field_idx
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2004.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2004
----
commit ff5b0a9d940d97361ad549081585ed75e1ab8d11
Author: Yijie Shen <he...@gmail.com>
Date: 2016-05-18T15:31:33Z
bug fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3926][TypeSystem]Incorrect implementati...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/2004#issuecomment-220086765
+1 to merge. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3926][TypeSystem]Incorrect implementati...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2004
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3926][TypeSystem]Incorrect implementati...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/2004#issuecomment-220133027
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-3926][TypeSystem]Incorrect implementati...
Posted by yjshen <gi...@git.apache.org>.
Github user yjshen commented on the pull request:
https://github.com/apache/flink/pull/2004#issuecomment-220068286
@fhueske @twalthr could you please take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---