You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2019/07/25 20:54:37 UTC

[Impala-ASF-CR] IMPALA-8795 : [WIP] Enable event polling by default in tests

Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13922


Change subject: IMPALA-8795 : [WIP] Enable event polling by default in tests
......................................................................

IMPALA-8795 : [WIP] Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. [WIP] Running all the tests with CDP build.

Change-Id: I7279349d4900e24fbcf558f290549496844ce138
---
M docker/catalogd/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 8:

(25 comments)

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@332
PS8, Line 332: w
flake8: E501 line too long (101 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@341
PS8, Line 341: ,
flake8: E501 line too long (117 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@350
PS8, Line 350: i
flake8: F821 undefined name 'impala_url'


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@384
PS8, Line 384: r
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py@971
PS8, Line 971: l
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py@971
PS8, Line 971:     """Confirm the database with 'db_name' is present in the impalad's local catalog. 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@43
PS8, Line 43: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@63
PS8, Line 63: R
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@77
PS8, Line 77: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@79
PS8, Line 79:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@79
PS8, Line 79:  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@86
PS8, Line 86: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@88
PS8, Line 88:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@88
PS8, Line 88:  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@91
PS8, Line 91: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@103
PS8, Line 103:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@103
PS8, Line 103:  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@112
PS8, Line 112:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@112
PS8, Line 112:  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@121
PS8, Line 121:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@121
PS8, Line 121:  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_hive_parquet_codec_interop.py
File tests/custom_cluster/test_hive_parquet_codec_interop.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_hive_parquet_codec_interop.py@91
PS8, Line 91: E
flake8: F821 undefined name 'EventProcessorUtils'


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py
File tests/metadata/test_refresh_partition.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@66
PS8, Line 66:  
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@66
PS8, Line 66:       EventProcessorUtils.wait_for_event_processing(self.hive_client) 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@136
PS8, Line 136: "
flake8: E126 continuation line over-indented for hanging indent



-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 06:49:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 7:

(24 comments)

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@332
PS7, Line 332: w
flake8: E501 line too long (101 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@341
PS7, Line 341: ,
flake8: E501 line too long (117 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@350
PS7, Line 350: i
flake8: F821 undefined name 'impala_url'


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@384
PS7, Line 384: r
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py@971
PS7, Line 971: l
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py@971
PS7, Line 971:     """Confirm the database with 'db_name' is present in the impalad's local catalog. 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/custom_cluster/test_hive_parquet_codec_interop.py
File tests/custom_cluster/test_hive_parquet_codec_interop.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/custom_cluster/test_hive_parquet_codec_interop.py@91
PS7, Line 91: E
flake8: F821 undefined name 'EventProcessorUtils'


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py
File tests/metadata/test_refresh_partition.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py@66
PS7, Line 66:  
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py@66
PS7, Line 66:       EventProcessorUtils.wait_for_event_processing(self.hive_client) 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@22
PS7, Line 22: import logging
flake8: F401 'logging' imported but unused


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@28
PS7, Line 28: class EventProcessorUtils(object):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@31
PS7, Line 31: @
flake8: E301 expected 1 blank line, found 0


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@47
PS7, Line 47: T
flake8: F821 undefined name 'TimeoutError'


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@49
PS7, Line 49: .
flake8: E131 continuation line unaligned for hanging indent


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@53
PS7, Line 53:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@53
PS7, Line 53:  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@54
PS7, Line 54:  
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@54
PS7, Line 54:   @staticmethod 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@62
PS7, Line 62:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@62
PS7, Line 62:  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@66
PS7, Line 66:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@66
PS7, Line 66:  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@69
PS7, Line 69:  
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@69
PS7, Line 69:  
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 22:07:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4700/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 06:02:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4816/


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 11:01:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 4: Code-Review+2

Looks like this just hit the issues we had with start-impala-cluster. Not sure if this is superseded by the other change, but this still looks OK


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 06:33:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.

Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................

IMPALA-8795 : Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I7279349d4900e24fbcf558f290549496844ce138
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/metadata/test_hms_integration.py
3 files changed, 16 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/4
-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 4:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4700/


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 07:38:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4742/


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 00:31:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4668/


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Jul 2019 06:25:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4677/


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Jul 2019 10:28:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4036/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 21:53:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Tim Armstrong has removed a vote on this change.

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4868/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 9
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 18:20:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 22:47:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4816/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 06:51:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.

Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................

IMPALA-8795 : Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I7279349d4900e24fbcf558f290549496844ce138
---
M docker/catalogd/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.

Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................

IMPALA-8795 : Enable event polling by default in tests

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing done [WIP]:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I7279349d4900e24fbcf558f290549496844ce138
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
A tests/util/event_processor_utils.py
8 files changed, 157 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/13922/7
-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4756/


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 02:14:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 9: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4868/


-- 
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 9
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 23:15:32 +0000
Gerrit-HasComments: No