[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2841: [Improve][Connector-V2] Improve read parquet

[GitBox <gi...@apache.org>]

TyrantLucifer commented on code in PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#discussion_r977276478


##########
seatunnel-connectors-v2/connector-file/connector-file-hadoop/pom.xml:
##########
@@ -40,4 +40,44 @@
             <artifactId>flink-shaded-hadoop-2</artifactId>
         </dependency>
     </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-shade-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <phase>package</phase>
+                        <goals>
+                            <goal>shade</goal>
+                        </goals>
+                        <!-- base module need skip shading -->
+                        <configuration>
+                            <relocations>
+                                <relocation>
+                                    <pattern>org.apache.avro</pattern>
+                                    <shadedPattern>${seatunnel.shade.package}.org.apache.avro</shadedPattern>

Review Comment:
   > Will `${seatunnel.shade.package}.org.apache.avro` conflict with other connector shade class name?
   
   Yes, it will conflict with spark.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org