You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/22 03:13:40 UTC

[GitHub] [kafka] rushsky518 opened a new pull request #8911: inLock is redundant in ControllerEventManager 

rushsky518 opened a new pull request #8911:
URL: https://github.com/apache/kafka/pull/8911


   LinkedBlockingQueue is threadsafe for put, outter inLock is unnecessary.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #8911: inLock is redundant in ControllerEventManager

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8911:
URL: https://github.com/apache/kafka/pull/8911#issuecomment-650788436


   Thanks for the PR. The lock is necessary. Check `clearAndPut` for an example.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma edited a comment on pull request #8911: inLock is redundant in ControllerEventManager

Posted by GitBox <gi...@apache.org>.
ijuma edited a comment on pull request #8911:
URL: https://github.com/apache/kafka/pull/8911#issuecomment-650788436


   Thanks for the PR. The lock is necessary. Check `clearAndPut` for an example. Happy to discuss further, if this is unclear.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma closed pull request #8911: inLock is redundant in ControllerEventManager

Posted by GitBox <gi...@apache.org>.
ijuma closed pull request #8911:
URL: https://github.com/apache/kafka/pull/8911


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org