You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xmlrpc-dev@ws.apache.org by "Walter Mundt (JIRA)" <xm...@ws.apache.org> on 2005/12/30 01:29:03 UTC

[jira] Created: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
--------------------------------------------------------------------

         Key: XMLRPC-75
         URL: http://issues.apache.org/jira/browse/XMLRPC-75
     Project: XML-RPC
        Type: New Feature
  Components: Source  
    Versions: unspecified    
    Reporter: Walter Mundt


I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.

I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.

I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by Walter Mundt <Wa...@coleengineering.com>.
Jochen Wiedmann (JIRA) wrote:
> I apologize, but I am unhappy with the overloading.
> 
> While I accept, that it might be suitable in certain situations, I do not think that it should be the default.

Well, I very much disagree.  I believe that overloading is an inherent 
and very useful part of the Java programming language, and that any 
library that purports to make a java class's methods available over some 
external mechanism should support it to the maximum degree possible.

 > In particular, I do not think that the selection of the right method
 > via reflection should occur with any method invocation. That's
 > something we had in version 2 and have just successfully managed to
 > get rid of.

Hmm, an interesting point, although not one I feel is sufficient to 
justify discarding support for a feature common to both the Java 
language and the XML-RPC protocol.

> IMO, the AbstractReflectiveHandlerMapping should support a single
 > method per name only. There is no reason for not adding more
 > complicated subclasses, if you like that.

I don't like this approach, because that means that any existing 
subclasses of AbstractReflectiveHandlerMapping lose the option of 
supporting reflection, short of subclassing those, too.

Rather, if you really feel that reflection is a negative, why not add a 
mechanism for choosing to use it within 
AbstractReflectiveHandlerMapping, and disable it by default?  If it is 
done by a public setter method, then minimal additional work in 
subclasses would be required to support both options.  Different 
handlers could be constructed based on the setting of a field, so that 
reflective overhead is not added when overloading is disabled.

-Walter

[jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12368078 ] 

Jochen Wiedmann commented on XMLRPC-75:
---------------------------------------

Walter,

I apologize, but I am unhappy with the overloading.

While I accept, that it might be suitable in certain situations, I do not think that it should be the default. In particular, I do not think that the selection of the right method via reflection should occur with any method invocation. That's something we had in version 2 and have just successfully managed to get rid of.

IMO, the AbstractReflectiveHandlerMapping should support a single method per name only. There is no reason for not adding more complicated subclasses, if you like that.

Jochen


> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12361418 ] 

Jochen Wiedmann commented on XMLRPC-75:
---------------------------------------

I haven't had the time to carefully read through your patch. I do not know "Aaron Hamid's Introspection patch" not do I now the one from xmlrpc-c.sf.net.

To me, it currently looks like yet another handler mapping. I wouldn't refuse the idea to add a different handler mapping to the source tree. The handler mapping API was written specifically with different mappings in mind. Otoh, not every mapping must be a port of the XML-RPC core distribution.

What I currently would like to see, would be some sentences, that describe what the differences between the default handler mapping and your suggestions are. What advantages, what disadvantages, and so on.


> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12361451 ] 

Walter Mundt commented on XMLRPC-75:
------------------------------------

I am sorry if my descriptions are insufficient.  I am not sure what you are saying in your last sentence, but in case you would like more information I will try to answer the issues you raise.

a) This is correct.  Other languages to implement this sub-protocol.  I did not link to the pages specifically concerned with this before; here are those links (in alphabetical order by language):
C/C++: http://xmlrpc-c.sourceforge.net/doc/libxmlrpc_server.html#systemmethod
.NET/C#: http://www.xml-rpc.net/faq/xmlrpcnetfaq.html#3.5
PHP: http://www.php.net/manual/en/function.xmlrpc-server-add-introspection-data.php
Python: http://docs.python.org/lib/simple-xmlrpc-servers.html (see register_introspection_functions) and http://docs.python.org/lib/serverproxy-objects.html

The second Python link provides a very good description of the three functions this patch is concerned with implementing.

b) Also correct.  However, what it does with introspection is quite different; rather than using it to implement a simple named method call operation, it essentially translates remote introspection requests into local Java reflection API calls.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by Walter Mundt <Wa...@coleengineering.com>.
> 
> Walter, I have committed some changes, that make AbstractReflectiveXmlRpcHandlerMapping implement the XmlRpcMetaDataHandlerMapping interface. Please, note the following:
> 
> - The implementation ensures, that the various "system.*" methods return
>   consistent result. In particular, a method returned by "system.listMethods"
>   is always able to provide a meaningful result for "system.methodSignature"
>   and "system.methodHelp".

I don't think this is the right approach.  My preference would be to 
provide as much information through the interface as possible.  I don't 
think it inconsistent to list methods for which signatures are 
unavailable: better to say "it's there, and that's all the information I 
can provide" then to hide methods which do not support the metadata 
interfaces.

> - I did not implement overloading. My goal is to keep the base classes simple
>   and clean. I am still open for subclasses, which allow overloading.
I still disagree with this approach.  Overloading is a basic feature 
that _is_ quite simple, and requiring the addition of a subclass to 
implement it results in a poor design where other parts of the code 
unrelated to overloading also have to be reimplemented.

I'll work on a way to abstract it out without compromising on the 
cleanliness of the architecture, but in my not-so-humble opinion this 
extra effort is unreasonable because I don't see why anyone would NOT 
want overloading support.  It can't do any harm, and it me it seems 
unintuitive to map classes with overloaded methods to an RPC interface 
by just picking one of them and using that, _especially_ when the RPC 
interface itself supports overloading.

I'm sorry to be bringing this argument about overloading into the 
mostly-unrelated context of metadata support, but I'm just completely 
failing to understand the reasoning that justifies removing what I see 
as an important and fairly basic feature of the library.  Upgrades are 
supposed to enhance functionality, not remove it.

> - The code is not checked. It is quite likely, that you'll find bugs.
I'll look through it when I get some time.

> - Keep documentation in mind. If you need a pointer to the apt format, see
>   http://maven.apache.org/guides/mini/guide-apt-format.html
I will look at that later.

[jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12368808 ] 

Jochen Wiedmann commented on XMLRPC-75:
---------------------------------------

Walter, I have committed some changes, that make AbstractReflectiveXmlRpcHandlerMapping implement the XmlRpcMetaDataHandlerMapping interface. Please, note the following:

- The implementation ensures, that the various "system.*" methods return
  consistent result. In particular, a method returned by "system.listMethods"
  is always able to provide a meaningful result for "system.methodSignature"
  and "system.methodHelp".
- I did not implement overloading. My goal is to keep the base classes simple
  and clean. I am still open for subclasses, which allow overloading.
- The code is not checked. It is quite likely, that you'll find bugs.
- Keep documentation in mind. If you need a pointer to the apt format, see
  http://maven.apache.org/guides/mini/guide-apt-format.html


> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=all ]

Walter Mundt updated XMLRPC-75:
-------------------------------

    Attachment: xmlrpc-2.0-beta-introspection.patch

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Zugewiesen: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=all ]

Jochen Wiedmann reassigned XMLRPC-75:
-------------------------------------

    Assign To: Jochen Wiedmann

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by Jochen Wiedmann <jo...@gmail.com>.
On 2/23/06, Walter Mundt <Wa...@coleengineering.com> wrote:

> Specifically, the simple "ws.addHandler(name, someRandomObject)"
> mechanism is _very_ handy, and going out to property files is, for my
> purposes (rapid prototyping and integration of code in different
> languages) vastly less convenient.  Therefore, before I have any
> interest in workin on the 3.0 branch, you'll have to agree to reinstate
> the older option of providing arbitrary Object instances at runtime to a
> handler mapping.

There is absolutely no reason, that prevents additional
implementations of XmlRpcHandlerMapping. Patches welcome.


Jochen


--
Whenever you find yourself on the side of the
majority, it is time to pause and reflect.
(Mark Twain)

Re: [jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by Walter Mundt <Wa...@coleengineering.com>.
Jochen Wiedmann (JIRA) wrote:
> Walter, are you interested in getting this into the 3.0 branch?

I am, but first I have a few issues with the 3.0 branch that I don't 
like.  First and foremost, the capabiliry to expose the methods on 
particular instances of a class has been removed and replaced with a 
default-constructor/proerty-file-based API that would be much less 
convenient for me to use.

Specifically, the simple "ws.addHandler(name, someRandomObject)" 
mechanism is _very_ handy, and going out to property files is, for my 
purposes (rapid prototyping and integration of code in different 
languages) vastly less convenient.  Therefore, before I have any 
interest in workin on the 3.0 branch, you'll have to agree to reinstate 
the older option of providing arbitrary Object instances at runtime to a 
handler mapping.

I don't care if the call structure changes to
((PropertyHandlerMapping)ws.getXmlRpcServer().getHandlerMapping()).addHandler(name, 
obj);
if that would be preferred, and I will whip up a quick patch to add such 
a call if you like.

> - First of all, you should propose necessary extensions for the interfaces handlermapping and handler.
>   (Recommended: Create an interface like XmlRpcMetaDataHandlerMapping, which extends
>   XmlRpcHandlerMapping.)
> - Second: Make the existing classes implement your new interfaces.
> - Third: Provide special handlers, which provide the requested metadata.

Can do, given the conditions above.


[jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12367476 ] 

Jochen Wiedmann commented on XMLRPC-75:
---------------------------------------

Walter, are you interested in getting this into the 3.0 branch?

If so, let's do it in a few steps.

- First of all, you should propose necessary extensions for the interfaces handlermapping and handler.
  (Recommended: Create an interface like XmlRpcMetaDataHandlerMapping, which extends
  XmlRpcHandlerMapping.)
- Second: Make the existing classes implement your new interfaces.
- Third: Provide special handlers, which provide the requested metadata.



> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=all ]

Walter Mundt updated XMLRPC-75:
-------------------------------

    Attachment: IntrospectionExample.java

I've deliberately left the API for enabling automatic intropection rather obtuse as of yet so that the community can decide how best to make it accessible from outside the library.  However, here is how you currently have to do it, for those that want to use the patch as-is.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12361444 ] 

Jochen Wiedmann commented on XMLRPC-75:
---------------------------------------

>From your comment, I conclude that

a) there are implementations in other languages, which do similar things and that
b) it is based on introspection

As for a), I still do miss a description what does happen. The links you mention above are much more generic and no specifications or something similar. As for b), the existing DefaultHandler is based on reflection itself.

In other words, I do not have the feeling to know more.



> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12412824 ] 

Jochen Wiedmann commented on XMLRPC-75:
---------------------------------------

Returning to the discussions on xmlrpc-user: Considering the fact, that overloading was possible with version 2, I find that I should drop my position. Consequently I have today added support for method overloading.

Walter, I'd really hope that you finish your good work by adding some docs.


> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature

>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xmlrpc-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: xmlrpc-dev-help@ws.apache.org


[jira] Updated: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=all ]

Walter Mundt updated XMLRPC-75:
-------------------------------

    Attachment: xmlrpc3-metadata.diff

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12367610 ] 

Walter Mundt commented on XMLRPC-75:
------------------------------------

Oops!  My earlier comment is incorrect.  The attached patch _includes_ the changes from XMLRPC-76, sorry.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12367682 ] 

Walter Mundt commented on XMLRPC-75:
------------------------------------

Oh, the patch also adds method overloading support to AbstractReflectiveHandlerMapping, so that, for example, a class that implements both foo(String) and foo(String[]) for some operation can make both versions available via XML-RPC.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12361403 ] 

Walter Mundt commented on XMLRPC-75:
------------------------------------

By the way, the fault codes I use in the patch are from here:
http://xmlrpc-epi.sourceforge.net/specs/rfc.fault_codes.php

If you don't like using the codes from that RFC, feel free to change them back to zeros; I don't much care either way.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=all ]

Walter Mundt updated XMLRPC-75:
-------------------------------

    Attachment: xmlrpc3-metadata.diff

Oops!  Minor fix, forgot to adjust a couple of references to the constructors for PropertyHandlerMapping that I changed to support overloading as an optional feature.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by Walter Mundt <Wa...@coleengineering.com>.
Jochen Wiedmann (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12367658 ] 
> 
> Jochen Wiedmann commented on XMLRPC-75:
> ---------------------------------------
> 
> Walter, I have added the interfaces XmlRpcListableHandlerMapping, and XmlRpcMetaDataHandler. Please note:
> 
> - I have added some comments. They represent my thoughts. As such, they are questionable.
>   Please read them carefully and verify, whether they meet your expectations.

Hmm, they seem to be based on the PHP implementation of these methods, 
and I'm not sure of the meaning of the one describing the expected 
behavior of system.methodSignature for a non-signature-supporting 
method.  My thought is to just return an empty outer list.

Also, should there be a difference between the "method does not support 
X" response and the "no such method" response?  I am thinking to return 
an empty result for the first, and give a "fault" response 
(XmlRpcException) for the second.

> - I have added methods getMethodSignatures() and getMethodHelp() to the handler mapping.
>   Obviously, the will usually be implemented by simply calling the respective handlers
>   methods. However, I find it thinkable, that a handler mapping will not do this.
Hmm, I think I see your point, although it does mean adding boilerplate 
code for any mapping that does the expected thing.

> If the above is fine for you, then I suggest the following steps to follow:
> 
> - Modify your XmlRpcSystemImpl to use the handler mapping methods.
>   (Nice idea, btw, to implement it like this. Did you note, that it can easily be
>   added to the property mappings by simply adding a property "system"?
>   Dynamic addition isn't required.)
Actually, because it has no zero-argument constructors, the current 
PropertyHandlerMapping cannot instantiate it.  I'm adding support for 
passing itself to objects when necessary.

> - Make the default handler mappings implement listable handler mapping.
> - Same for the default handlers, which should implement metadata handler.
Working on this now.

[jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12367658 ] 

Jochen Wiedmann commented on XMLRPC-75:
---------------------------------------

Walter, I have added the interfaces XmlRpcListableHandlerMapping, and XmlRpcMetaDataHandler. Please note:

- I have added some comments. They represent my thoughts. As such, they are questionable.
  Please read them carefully and verify, whether they meet your expectations.
- I have added methods getMethodSignatures() and getMethodHelp() to the handler mapping.
  Obviously, the will usually be implemented by simply calling the respective handlers
  methods. However, I find it thinkable, that a handler mapping will not do this.

If the above is fine for you, then I suggest the following steps to follow:

- Modify your XmlRpcSystemImpl to use the handler mapping methods.
  (Nice idea, btw, to implement it like this. Did you note, that it can easily be
  added to the property mappings by simply adding a property "system"?
  Dynamic addition isn't required.)
- Make the default handler mappings implement listable handler mapping.
- Same for the default handlers, which should implement metadada handler.





> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12361436 ] 

Walter Mundt commented on XMLRPC-75:
------------------------------------

Don't worry about the original patches then, as they're not terrribly relevant -- they're both around 3-4 years old at this point, thus this new attempt.  However, this is not just "yet another handler mapping."  It adds a new interface that custom handlers can implement to support introspection, as well as a new derived Invoker that implements this interface using Java reflection.  It also adds a new ContextXmlRpcHandler which makes use of this interface to actually implement the method calls specified by the introspection API, and a function in the SystemHandler to enable those methods if it is so desired.

First, I will argue that this is a useful addition to the library.  Second, I will argue that this code belongs in the core distribution.

For the first point:
While introspection is not part of the XML-RPC specification, it is a very useful feature for automatic discovery of services and proxy interface generation, among other things.  This particular introspection interface is supported both by the PHP XML-RPC extension here: http://us3.php.net/manual/en/ref.xmlrpc.php and the standard Python XML-RPC server library (although the latter doesn't yet support methodSignature queries automatically).  Supporting it here would mean that this library would behave more similarly to other XML-RPC implementations that are available; whether this is desirable in and of itself is debatable, but I think it is if there is no downside to the proposition.

For the second:
First of all, it's harmless for those who do not wish to take advantage of it.  None of the code for actually calling a particular RPC method is changed, so the only possible performance change is (very) slightly larger code size.  Second, as I mentioned above, having it bundled increases similarity with other XML-RPC implementations.  Third, some changes, that make the introspection API easier to use, such as the new introspection-related methods on the SystemHandler and DefaultHandlerMapping class, and the addition of introspection support to the SystemHandler, could not be implemented as elegantly were the introspection code to be published and maintained separately.
Finally, if introspection is not merged into the main source tree, this patch will likely end up out-of-date and useless, just as the previous one did, resulting in people who need introspection support sticking with older versions of the library and being unable to contribute to the project's current code.  On the other hand, if it is merged, then it should be fairly easy to see when it breaks and fix it as the changes that require it to be updated are made.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Kommentiert: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Jochen Wiedmann (JIRA)" <xm...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/XMLRPC-75?page=comments#action_12361479 ] 

Jochen Wiedmann commented on XMLRPC-75:
---------------------------------------

I do now understand, that the "Introspection" stuff is more than a new handler mapping. Basically, it is providing metadata to the client.

I'll look through the code in the next week.


> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=all ]

Walter Mundt updated XMLRPC-75:
-------------------------------

    Attachment: xmlrpc3-metadata.diff

How's this patch?  Note that this assumes the patch from XMLRPC-76 has already been applied.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=all ]

Walter Mundt updated XMLRPC-75:
-------------------------------

    Attachment: xmlrpc3-metadata.diff

Alright, if you insist, here's a version that makes overloading support an optional (and disabled-by-default) feature.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (XMLRPC-75) Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)

Posted by "Walter Mundt (JIRA)" <xm...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/XMLRPC-75?page=all ]

Walter Mundt updated XMLRPC-75:
-------------------------------

    Attachment: xmlrpc3-metadata.diff

Okay, here is an updated patch which uses your interfaces.  It also adds support in PropertyHandlerMapping for automatically passing the mapping to the constructor for any object specified in the property file.  This could be used to subclass PHM and store additional information used by the various XML-RPC services.

> Introspection Patch for XML-RPC, current to SVN 2005-12-29 (r359943)
> --------------------------------------------------------------------
>
>          Key: XMLRPC-75
>          URL: http://issues.apache.org/jira/browse/XMLRPC-75
>      Project: XML-RPC
>         Type: New Feature
>   Components: Source
>     Versions: unspecified
>     Reporter: Walter Mundt
>     Assignee: Jochen Wiedmann
>  Attachments: IntrospectionExample.java, xmlrpc-2.0-beta-introspection.patch, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff, xmlrpc3-metadata.diff
>
> I've taken Aaron Hamid's Introspection patch (which was in turn derived from the one here: http://xmlrpc-c.sourceforge.net/hacks/helma-xmlrpc-introspection.diff ) and basically rewritten it to work with the current XML-RPC library.
> I tried to set it up so that it followed the existing coding style as much as possible, and would not break any existing applications.  For example, when I needed a list of handlers supported by a particular mapping, I added a new interface XmlRpcListableHandlerMapping that provides this information, made the default handler implement it, and designed my code so that if it were not implemented by a handler in use, everything  would work except the system.listMethods functionality that relies on it.
> I hope you will be able to integrate this code into the next version of the library; please contact me with any questions or issues.  I will be attaching the patch to this issue if I can so that the problem with his previous patch will not occur.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira