[GitHub] [cloudstack] ravening commented on pull request #3969: Snapshot deletion issues

[GitBox <gi...@apache.org>]

ravening commented on pull request #3969:
URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-684798057


   @DaanHoogland @GabrielBrascher @andrijapanicsb @rhtyd 
   
   Found an issue with this commit. Below are the steps to reproduce
   
   1. Create VM snapshot from running vm
   2. Create a snapshot from the above VM snapshot
   3. Delete the snapshot
   4. Try to create snapshot again. This will fail.
   This is because when we delete the snapshot for the first time, its deleting the VM snapshot as well in the primary storage.
   So when we try to create snapshot again, its not able to find the vm snapshot and throws an exception
   
   
   I have made a fix so that it checks if the vm snapshot from which the snapshot is created, still exists on primary storage or not. If it exists then its not deleted from primary but only from secondary


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org