[GitHub] [hadoop] Hexiaoqiao commented on pull request #3595: HDFS-16283: RBF: improve renewLease() to call only a specific NameNod…

[GitBox <gi...@apache.org>]

Hexiaoqiao commented on pull request #3595:
URL: https://github.com/apache/hadoop/pull/3595#issuecomment-954466025


   Thanks for bringing this improvement. Sorry I do not receive discussion in mail-list and reply here directly.
   I am not sure if it is the best solution to expose namespace id to client which will confuse the end-user in my opinion.
   `If we are adding new protocols, maybe we can add "renewLease(String clientName, String path)" and let Router do the resolve from path to namespace.`
   In my practice, I think `path` will be the good choice here. Strong +1. And router could resolve it which keep the same logic for other interface. But the bad news is that it will increase the invoke interface times. Anyway, I think this solution will not break anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org