You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Dan Smith (Jira)" <ji...@apache.org> on 2019/12/24 19:08:00 UTC

[jira] [Created] (GEODE-7623) AlertingAction thread local looks like it will no longer have any effect

Dan Smith created GEODE-7623:
--------------------------------

             Summary: AlertingAction thread local looks like it will no longer have any effect
                 Key: GEODE-7623
                 URL: https://issues.apache.org/jira/browse/GEODE-7623
             Project: Geode
          Issue Type: Bug
          Components: logging, membership
            Reporter: Dan Smith


From code inspection, it looks like the changes in dffcb944 have made the AlertingAction class effectively useless.

The class has a thread local that is set when we start sending an alert. But dffcb944 changed the alert process such that shortly after the thread local is set, the bulk of the alerting logic happens in a *separate* thread, without the thread local, in ClusterAlertMessaging.sendAlert.

Therefore, this thread local has no effect. If this behavior was previously useful, we need to set the thread local inside this new executor thread, perhaps? Or find some other way to prevent the executor from triggering new alerts?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)