[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

[Cazen <gi...@git.apache.org>]

Github user Cazen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10497#discussion_r48684498
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONOptions.scala ---
    @@ -59,6 +62,8 @@ object JSONOptions {
         allowNumericLeadingZeros =
           parameters.get("allowNumericLeadingZeros").map(_.toBoolean).getOrElse(false),
         allowNonNumericNumbers =
    -      parameters.get("allowNonNumericNumbers").map(_.toBoolean).getOrElse(true)
    +      parameters.get("allowNonNumericNumbers").map(_.toBoolean).getOrElse(true),
    +    allowBackslashEscapingAnyCharacter =
    +      parameters.get("allowBackslashEscapingAnyCharacter").map(_.toBoolean).getOrElse(true)
    --- End diff --
    
    Happy New Year Owen!
    
    At first, I've created PR with false default.
    
    But Xin advised to me that "I'd actually change the default value to true" in previous comment so I've changed.
    
    If you think it doesn't make sense, please call me again. I will change that immediately
    
    Thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org